Skip to content

Cyclop no longer working #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
huornlmj opened this issue Jun 28, 2023 · 3 comments
Closed
4 tasks done

Cyclop no longer working #3928

huornlmj opened this issue Jun 28, 2023 · 3 comments
Labels
question Further information is requested

Comments

@huornlmj
Copy link

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc.).
  • Yes, I've tried with the standalone linter if available (e.g., gocritic, go vet, etc.). (https://golangci-lint.run/usage/linters/)

Description of the problem

When I run

$ golangci-lint run ./... --disable-all -E cyclop --no-config

I only get (typecheck) results, not (cyclop) results.

Version of golangci-lint

(1.53.3)

Configuration file

None

Go environment

$ go version && go env
go version go1.18.1 linux/amd64
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/user/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.18"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.18/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/user/source/REDACTED/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build763151559=/tmp/go-build -gno-record-gcc-switches"

Verbose output of running

None

Code example or link to a public repository

// add your code here
@huornlmj huornlmj added the bug Something isn't working label Jun 28, 2023
@ldez ldez added question Further information is requested and removed bug Something isn't working labels Jun 28, 2023
@ldez
Copy link
Member

ldez commented Jun 28, 2023

Hello,

typecheck is not a real linter it's just a way to parse/display "compilation" and linters errors (linter reports are not errors).
So if you have typecheck reports, you will not have other reports.

@ldez ldez closed this as completed Jun 28, 2023
@huornlmj
Copy link
Author

Sorry but that's not actually what the issue is. The problem is that even though I'm only enabling the cyclop checker, cyclop doesn't appear to be running. Instead, the typecheck checker is running, even though I've disabled all checkers and only enabled cyclop.

@ldez
Copy link
Member

ldez commented Jun 28, 2023

Can you provide the reproducible example (code and configuration) asked in the issue template?

FYI, typecheck is not a real linter, it cannot be disabled because of that.

Note: we have tests that run on all PRs and all commits to be sure that linters work: https://github.com/golangci/golangci-lint/tree/master/test/testdata

The documentation about typecheck will be improved in #3929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants