Skip to content

docs: missing image version for the Docker installation #3103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
robel-yemane opened this issue Aug 16, 2022 · 2 comments
Closed
4 tasks done

docs: missing image version for the Docker installation #3103

robel-yemane opened this issue Aug 16, 2022 · 2 comments
Labels
area: docs bug Something isn't working

Comments

@robel-yemane
Copy link

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).
  • Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

The docker installation method specified in the website and/or README is inaccurate

The command as specified here https://golangci-lint.run/usage/install/#docker i.e.

docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint: golangci-lint run -v

is not executable and results in a docker error

docker: invalid reference format.
See 'docker run --help'.

suggested fix:

docker run --rm -v $(pwd):/app -w /app golangci/golangci-lint golangci-lint run -v

Version of golangci-lint

$ golangci-lint --version
golangci-lint has version v1.48.0 built from 2d8fea81 on 2022-08-04T19:06:48Z

Configuration file

$ cat .golangci.yml
N/A

Go environment

$ go version && go env
N/A

Verbose output of running

$ golangci-lint cache clean
$ golangci-lint run -v
N/A

Code example or link to a public repository

N/A
@robel-yemane robel-yemane added the bug Something isn't working label Aug 16, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 16, 2022

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@ldez ldez changed the title Docker golangci-lint installation bug docs: missing image version for the Docker installation Aug 17, 2022
@ldez
Copy link
Member

ldez commented Aug 20, 2022

hello,

the problem is fixed, it was just a bug during the generation of the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants