Skip to content

tyepcheck linter is running even when disabled #2847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
adamdecaf opened this issue May 12, 2022 · 1 comment
Closed
4 tasks done

tyepcheck linter is running even when disabled #2847

adamdecaf opened this issue May 12, 2022 · 1 comment
Labels
duplicate This issue or pull request already exists question Further information is requested

Comments

@adamdecaf
Copy link

adamdecaf commented May 12, 2022

Welcome

  • Yes, I'm using a binary release within 2 latest major releases. Only such installations are supported.
  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've included all information below (version, config, etc).
  • Yes, I've tried with the standalone linter if available. (https://golangci-lint.run/usage/linters/)

Description of the problem

The typecheck linter is running even while disabled.

level=info msg="[lintersdb] Active 18 linters: [asciicheck bidichk bodyclose deadcode durationcheck exhaustive gosec gosimple govet ineffassign misspell nolintlint rowserrcheck sqlclosecheck staticcheck structcheck unused varcheck]"

Error:

invalid operation: cannot compare env.Logger == nil (operator == not defined on untyped nil) (typecheck)

Version of golangci-lint

golangci-lint has version 1.46.1 built from 044f0a17 on 2022-05-12T09:23:45Z

Configuration file

-E=asciicheck,bidichk,bodyclose,exhaustive,durationcheck,gosec,misspell,nolintlint,rowserrcheck,sqlclosecheck

-D=typecheck

Source: https://github.com/moov-io/infra/blob/master/go/lint-project.sh#L140

Go environment

go version go1.18.2 linux/amd64

Verbose output of running

golangci/golangci-lint info checking GitHub for tag 'v1.46.1'
golangci/golangci-lint info found version: 1.46.1 for v1.46.1/linux/amd64
golangci/golangci-lint info installed ./bin/golangci-lint
golangci-lint has version 1.46.1 built from 044f0a17 on 2022-05-12T09:23:45Z
level=info msg="[config_reader] Config search paths: [./ /home/actions/actions-runner/_work/fraudwall/fraudwall /home/actions/actions-runner/_work/fraudwall /home/actions/actions-runner/_work /home/actions/actions-runner /home/actions /home /]"
level=info msg="[lintersdb] Active 18 linters: [asciicheck bidichk bodyclose deadcode durationcheck exhaustive gosec gosimple govet ineffassign misspell nolintlint rowserrcheck sqlclosecheck staticcheck structcheck unused varcheck]"
level=info msg="[loader] Using build tags: [static]"
level=info msg="[loader] Go packages loading at mode 575 (types_sizes|compiled_files|files|imports|name|deps|exports_file) took 401.144014ms"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 4.537989ms"
level=info msg="[linters context/goanalysis] analyzers took 27.465899ms with top 10 stages: fact_purity: 439.321µs, SA4023: 426.369µs, bidichk: 393.33µs, directives: 346.819µs, inspect: 333.226µs, buildir: 318.439µs, SA5012: 302.941µs, typedness: 294.718µs, SA9007: 286.46µs, nilness: 285.431µs"
level=warning msg="[linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the https://github.com/golangci/golangci-lint/issues/2649."
level=info msg="[runner] Issues before processing: 3473, after processing: 23"
level=info msg="[runner] Processors filtering stat (out/in): identifier_marker: 3473/3473, exclude-rules: 3473/3473, max_same_issues: 23/23, path_prefixer: 23/23, cgo: 3473/3473, skip_dirs: 3473/3473, severity-rules: 23/23, filename_unadjuster: 3473/3473, nolint: 3473/3473, sort_results: 23/23, path_prettifier: 3473/3473, source_code: 23/23, exclude: 3473/3473, uniq_by_line: 23/3473, diff: 23/23, max_per_file_from_linter: 23/23, max_from_linter: 23/23, path_shortener: 23/23, skip_files: 3473/3473, autogenerated_exclude: 3473/3473"
level=info msg="[runner] processing took 352.299718ms with stages: exclude-rules: 260.541674ms, identifier_marker: 87.532[164](https://github.com/moovfinancial/fraudwall/runs/6411133745?check_suite_focus=true#step:8:164)ms, path_prettifier: 1.57663ms, nolint: 1.21846ms, skip_dirs: 406.41µs, cgo: 341.99µs, filename_unadjuster: 226.23µs, autogenerated_exclude: 219.57µs, uniq_by_line: 161.75µs, source_code: 54.46µs, max_same_issues: 10.35µs, path_shortener: 3.62µs, max_from_linter: 2.46µs, max_per_file_from_linter: 2.41µs, exclude: 360ns, sort_results: 270ns, diff: 270ns, skip_files: 260ns, severity-rules: 240ns, path_prefixer: 140ns"
level=info msg="[runner] linters took 4.745539054s with stages: goanalysis_metalinter: 4.393103296s, structcheck: 24.84µs"
level=info msg="File cache stats: 5 entries of total size 15.2KiB"
level=info msg="Memory: 53 samples, avg is 260.7MB, max is 323.3MB"
level=info msg="Execution took 5.155983136s"

Error: pkg/service/environment.go:75:19: invalid operation: cannot compare env.Logger == nil (operator == not defined on untyped nil) (typecheck)
	if env.Logger == nil {
	                 ^

Code example or link to a public repository

@adamdecaf adamdecaf added the bug Something isn't working label May 12, 2022
@adamdecaf
Copy link
Author

For reference #1272 (comment)

@ldez ldez added question Further information is requested duplicate This issue or pull request already exists and removed bug Something isn't working labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants