golangci-lint linters should have an output that is formattable

[georgettica]

Your feature request related to a problem? Please describe.

I wanted to get all of the fast linters, and to do that I need to grep the data I retrieve.

Describe the solution you'd like.

I would want the --out-format to be respected here and if it's json it'll output the data in a json struct

if any other data is provided it'll push a warning it cannot parse in that type and continue with the default output.

Describe alternatives you've considered.

0. keep as is and show grep out of it: possible but not portable
1. use json: preferred

Additional context.

No response

[boring-cyborg]

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

[georgettica]

Looked at the guide and this is a general question before implementation

[ldez]

Hello,

Your issue is unclear, can you describe your suggestion a bit more?

[georgettica]

We could

1. change printLinterConfigs https://github.com/golangci/golangci-lint/blob/ef928947b59010016d4626566798b2fc21189476/pkg/commands/help.go#L40to recieve also the output format and print according to it
2. Wrap calls with if statement and print differently based on it

   golangci-lint/pkg/commands/linters.go

   Line 40 in ef92894

   printLinterConfigs(enabledLinters)

It's just I want to

$ golangci-lint command ... | jq '.[] | select(.speed == "fast")'

[georgettica]

The implementation of this in the run.go is

golangci-lint/pkg/commands/run.go

Line 467 in d209389

func (e *Executor) createPrinter(format string, w io.Writer) (printers.Printer, error) {

And I raised this issue because the flag was also present on this command (run golangci-lint linters --help for information)

[ldez]

Why do you want to filter the output of golangci-lint linters --help to get fast linters?

[georgettica]

I meant that

$ golangci-lint linters --help | grep out-format
      --out-format string              Format of output: colored-line-number|line-number|json|tab|checkstyle|code-climate|html|junit-xml|github-actions (default "colored-line-number")

so the local command has the out-format flag, but it's unused

[ldez]

Why do you want to filter the output of golangci-lint linters --help to get fast linters?

[georgettica]

I want to run:

golangci-lint linters --out-format json | jq '.[] | select(.speed == "fast")'

[ldez]

Why?

[georgettica]

so I can have a dynamic list of the fast ones and run all of them

[ldez]

ok so you want the behavior described here: #1909 (comment)

[georgettica]

so you would say it's better to:

golangci-lint run --no-config --enable-all --fast

or the right permutation that is described in the issue mentioned?

[ldez]

I suppose because you don't provide a clear context, you want to filter on fast linters to be able to run only fast linters on your CI.
So the configuration file must be used for those linters.
If the --fast flag is able to only run the linters defined in the configuration file that are fast then your problem will be solved.

Note: It's important in an issue to explain the "why" instead of the "how" and provide a clear context, like that we can discuss solutions instead of implementation proposal.

[georgettica]

sorry I just read the contribution guide, and it didn't allow me the section of "Why do you want this change?"

felt it was directing me to be explicit on the "how"

[georgettica]

so yes, I wanted to take this command I put up top as a useful one-liner that takes a few seconds to run (based on the codebase)

for obvious reasons having all of these linters may be too much, but this might be something useful to drill down and fix :)

[georgettica]

I can close this card as the answer is to "use golangci-lint run" as it's where most of the logic is anyways :)