Skip to content

More configurable goconst #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Antonboom opened this issue Nov 6, 2020 · 3 comments · Fixed by #1500
Closed

More configurable goconst #1495

Antonboom opened this issue Nov 6, 2020 · 3 comments · Fixed by #1500
Assignees
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement

Comments

@Antonboom
Copy link
Contributor

Hello!
I have a question :)

I needed the flags in golangci-lint that are in the original goconst:
jgautheron/goconst#11

I wanted to do a PR and got confused where:

What is the difference?

What is the best way to proceed? Try to update the golangci/goconst fork and then updating golangci-lint or update golangci-lint so that it no longer links to the fork, but works with the original linter?

Judging by the issues at https://github.com/golangci/goconst, I'm not the only one :)

@Antonboom Antonboom added the enhancement New feature or improvement label Nov 6, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 6, 2020

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@iwankgb
Copy link
Contributor

iwankgb commented Nov 7, 2020

@Antonboom judging by this comparison: jgautheron/goconst@master...golangci:master the goal was to enable goconst to be used as a library. You may want to consider filing an issue in jgautheron/goconst asking about such a feature. In the meantime I will update our fork.

@iwankgb iwankgb self-assigned this Nov 7, 2020
@iwankgb iwankgb added the dependencies Relates to an upstream dependency label Nov 7, 2020
@Antonboom
Copy link
Contributor Author

Antonboom commented Nov 8, 2020

@iwankgb

Сan we now completely switch to the original linter? :)
jgautheron/goconst#11 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency enhancement New feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants