golint: deprecation (#1965)

ldez · web-flow · commit f95b1ed39fb5 · 2021-05-11T00:50:50.000+02:00
diff --git a/.golangci.yml b/.golangci.yml
@@ -34,8 +34,6 @@ linters-settings:
     min-complexity: 15
   goimports:
     local-prefixes: github.com/golangci/golangci-lint
-  golint:
-    min-confidence: 0
   gomnd:
     settings:
       mnd:
@@ -82,7 +80,6 @@ linters:
     - gocyclo
     - gofmt
     - goimports
-    - golint
     - gomnd
     - goprintffuncname
     - gosec
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
@@ -169,7 +169,8 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().
 			WithPresets(linter.PresetStyle).
-			WithURL("https://github.com/golang/lint"),
+			WithURL("https://github.com/golang/lint").
+			Deprecated("The repository of the linter has been archived by the owner.", "v1.41.0", "revive"),
 		linter.NewConfig(golinters.NewRowsErrCheck()).
 			WithSince("v1.23.0").
 			WithLoadForGoAnalysis().
diff --git a/test/run_test.go b/test/run_test.go
@@ -91,7 +91,7 @@ func TestTimeoutInConfig(t *testing.T) {
 
 func TestTestsAreLintedByDefault(t *testing.T) {
 	testshared.NewLintRunner(t).Run(getTestDataDir("withtests")).
-		ExpectHasIssue("`if` block ends with a `return`")
+		ExpectHasIssue("don't use `init` function")
 }
 
 func TestCgoOk(t *testing.T) {
diff --git a/test/testdata/default_exclude.go b/test/testdata/default_exclude.go
@@ -1,4 +1,4 @@
-//args: -Estylecheck,golint
+//args: -Estylecheck,golint --internal-cmd-test
 //config_path: testdata/configs/default_exclude.yml
 
 /*Package testdata ...*/
diff --git a/test/testdata/golint.go b/test/testdata/golint.go
@@ -1,4 +1,4 @@
-//args: -Egolint
+//args: -Egolint --internal-cmd-test
 package testdata
 
 var Go_lint string // ERROR "don't use underscores in Go names; var `Go_lint` should be `GoLint`"

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func TestTimeoutInConfig(t *testing.T) {`
`91`	`91`
`92`	`92`	`func TestTestsAreLintedByDefault(t *testing.T) {`
`93`	`93`	`testshared.NewLintRunner(t).Run(getTestDataDir("withtests")).`
`94`		- ExpectHasIssue("`if` block ends with a `return`")
	`94`	+ ExpectHasIssue("don't use `init` function")
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`func TestCgoOk(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-//args: -Estylecheck,golint`
	`1`	`+//args: -Estylecheck,golint --internal-cmd-test`
`2`	`2`	`//config_path: testdata/configs/default_exclude.yml`
`3`	`3`
`4`	`4`	`/Package testdata .../`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-//args: -Egolint`
	`1`	`+//args: -Egolint --internal-cmd-test`
`2`	`2`	`package testdata`
`3`	`3`
`4`	`4`	var Go_lint string // ERROR "don't use underscores in Go names; var `Go_lint` should be `GoLint`"