applies new requirements: now forbidogo is a slow linter

ldez · ldez · commit f5a69994d7f4 · 2023-02-27T22:21:58.000+01:00
diff --git a/pkg/golinters/forbidigo.go b/pkg/golinters/forbidigo.go
@@ -47,7 +47,7 @@ func NewForbidigo(settings *config.ForbidigoSettings) *goanalysis.Linter {
 		nil,
 	).WithIssuesReporter(func(*linter.Context) []goanalysis.Issue {
 		return resIssues
-	}).WithLoadMode(goanalysis.LoadModeSyntax)
+	}).WithLoadMode(goanalysis.LoadModeTypesInfo)
 }
 
 func runForbidigo(pass *analysis.Pass, settings *config.ForbidigoSettings) ([]goanalysis.Issue, error) {
diff --git a/pkg/lint/lintersdb/manager.go b/pkg/lint/lintersdb/manager.go
@@ -417,6 +417,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		linter.NewConfig(golinters.NewForbidigo(forbidigoCfg)).
 			WithSince("v1.34.0").
 			WithPresets(linter.PresetStyle).
+			WithLoadForGoAnalysis().
 			WithURL("https://github.com/ashanbrown/forbidigo"),
 
 		linter.NewConfig(golinters.NewForceTypeAssert()).

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func NewForbidigo(settings config.ForbidigoSettings) goanalysis.Linter {`
`47`	`47`	`nil,`
`48`	`48`	`).WithIssuesReporter(func(*linter.Context) []goanalysis.Issue {`
`49`	`49`	`return resIssues`
`50`		`- }).WithLoadMode(goanalysis.LoadModeSyntax)`
	`50`	`+ }).WithLoadMode(goanalysis.LoadModeTypesInfo)`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`func runForbidigo(pass analysis.Pass, settings config.ForbidigoSettings) ([]goanalysis.Issue, error) {`