dev: remove archived mitchellh/go-homedir

Author: alexandear

go.mod

@@ -77,7 +77,6 @@ require (
 	github.com/matoous/godox v0.0.0-20230222163458-006bad1f9d26
 	github.com/mattn/go-colorable v0.1.13
 	github.com/mgechev/revive v1.5.1
-	github.com/mitchellh/go-homedir v1.1.0
 	github.com/mitchellh/go-ps v1.0.0
 	github.com/moricho/tparallel v0.3.2
 	github.com/nakabonne/nestif v0.3.1

go.sum

@@ -7,9 +7,9 @@ import (
 	"os"
 	"path/filepath"
 	"slices"
+	"strings"
 
 	"github.com/go-viper/mapstructure/v2"
-	"github.com/mitchellh/go-homedir"
 	"github.com/spf13/pflag"
 	"github.com/spf13/viper"
 
@@ -129,9 +129,9 @@ func (l *Loader) evaluateOptions() (string, error) {
 		return "", errConfigDisabled
 	}
 
-	configFile, err := homedir.Expand(l.opts.Config)
+	configFile, err := expandHomeDir(l.opts.Config)
 	if err != nil {
-		return "", errors.New("failed to expand configuration path")
+		return "", fmt.Errorf("failed to expand configuration path: %w", err)
 	}
 
 	return configFile, nil
@@ -184,7 +184,7 @@ func (l *Loader) getConfigSearchPaths() []string {
 	}
 
 	// find home directory for global config
-	if home, err := homedir.Dir(); err != nil {
+	if home, err := os.UserHomeDir(); err != nil {
 		l.log.Warnf("Can't get user's home directory: %v", err)
 	} else if !slices.Contains(searchPaths, home) {
 		searchPaths = append(searchPaths, home)
@@ -473,3 +473,25 @@ func customDecoderHook() viper.DecoderConfigOption {
 		mapstructure.TextUnmarshallerHookFunc(),
 	))
 }
+
+// expandHomeDir expands file paths relative to the user's home directory (~) into absolute paths.
+func expandHomeDir(path string) (string, error) {
+	if !strings.HasPrefix(path, "~") {
+		return path, nil
+	}
+
+	homeDir, err := os.UserHomeDir()
+	if err != nil {
+		return "", err
+	}
+
+	if path == "~" {
+		return homeDir, nil
+	}
+
+	if !strings.HasPrefix(path, "~"+string(filepath.Separator)) {
+		return "", errors.New("cannot expand user-specific home dir")
+	}
+
+	return filepath.Join(homeDir, strings.TrimPrefix(path, "~")), nil
+}

pkg/config/loader.go

@@ -0,0 +1,40 @@
+package config
+
+import (
+	"os/user"
+	"path/filepath"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func Test_expandHomeDir(t *testing.T) {
+	u, err := user.Current()
+	require.NoError(t, err)
+
+	testCases := []struct {
+		path        string
+		expected    string
+		expectedErr bool
+	}{
+		{path: "", expected: ""},
+		{path: "~", expected: u.HomeDir},
+		{path: "/foo", expected: "/foo"},
+		{path: "\\foo", expected: "\\foo"},
+		{path: "C:\foo", expected: "C:\foo"},
+		{path: "~/foo/bar", expected: filepath.Join(u.HomeDir, "foo", "bar")},
+		{path: "~foo/foo", expectedErr: true},
+	}
+
+	for _, tc := range testCases {
+		actual, err := expandHomeDir(tc.path)
+
+		if tc.expectedErr {
+			require.Error(t, err)
+			return
+		}
+		require.NoError(t, err)
+		assert.Equal(t, tc.expected, actual)
+	}
+}