docs: replace default exclusions by exclusion presets

Author: ldez

assets/cli-help.json

@@ -169,12 +169,11 @@ You can see more examples of using `//nolint` in [our tests](https://github.com/
 
 Use `//nolint` instead of `// nolint` because machine-readable comments should have no space by Go convention.
 
-## Default Exclusions
+## Exclusion Presets
 
-Some exclusions are considered as common, to help golangci-lint users those common exclusions are used as default exclusions.
+Some exclusions are considered as common, to help golangci-lint users those common exclusions are provided through presets.
 
-If you don't want to use it you can set `issues.exclude-use-default` to `false`.
-{.DefaultExclusions}
+{.ExclusionPresets}
 
 ### Default Directory Exclusions
 

assets/default-exclusions.json

@@ -382,7 +382,7 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithURL("https://github.com/mvdan/gofumpt"),
 
 		linter.NewConfig(golines.New(&cfg.LintersSettings.GoLines)).
-			WithSince("v1.64.0").
+			WithSince("v2.0.0").
 			WithPresets(linter.PresetFormatting).
 			WithAutoFix().
 			WithURL("https://github.com/segmentio/golines"),

assets/exclusion-presets.json

@@ -2,7 +2,7 @@ package processors
 
 import "github.com/golangci/golangci-lint/pkg/config"
 
-var linterExclusionPresets = map[string][]config.ExcludeRule{
+var LinterExclusionPresets = map[string][]config.ExcludeRule{
 	config.ExclusionPresetComments: {
 		{
 			// Annoying issue about not having a comment. The rare codebase has such comments.
@@ -129,7 +129,7 @@ func getLinterExclusionPresets(names []string) []config.ExcludeRule {
 	var rules []config.ExcludeRule
 
 	for _, name := range names {
-		if p, ok := linterExclusionPresets[name]; ok {
+		if p, ok := LinterExclusionPresets[name]; ok {
 			rules = append(rules, p...)
 		}
 	}

assets/linters-info.json

@@ -12,6 +12,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
 	"github.com/golangci/golangci-lint/pkg/lint/lintersdb"
+	"github.com/golangci/golangci-lint/pkg/result/processors"
 	"github.com/golangci/golangci-lint/scripts/website/types"
 )
 
@@ -71,8 +72,21 @@ func saveLinters() error {
 }
 
 func saveDefaultExclusions() error {
-	// FIXME
-	return saveToJSONFile(filepath.Join("assets", "default-exclusions.json"), nil)
+	data := make(map[string][]types.ExcludeRule)
+
+	for name, rules := range processors.LinterExclusionPresets {
+		for _, rule := range rules {
+			data[name] = append(data[name], types.ExcludeRule{
+				Linters:    rule.Linters,
+				Path:       rule.Path,
+				PathExcept: rule.PathExcept,
+				Text:       rule.Text,
+				Source:     rule.Source,
+			})
+		}
+	}
+
+	return saveToJSONFile(filepath.Join("assets", "exclusion-presets.json"), data)
 }
 
 func saveCLIHelp(dst string) error {

docs/src/docs/usage/false-positives.mdx

@@ -3,22 +3,32 @@ package main
 import (
 	"bytes"
 	"path/filepath"
-	"strings"
 	"text/template"
 
 	"github.com/golangci/golangci-lint/scripts/website/types"
 )
 
-const exclusionTmpl = `{{ $tick := "` + "`" + `" }}
-### {{ .ID }}
-
-- linter: {{ $tick }}{{ .Linter }}{{ $tick }}
-- pattern: {{ $tick }}{{ .Pattern }}{{ $tick }}
-- why: {{ .Why }}
-`
-
-func getDefaultExclusions() (string, error) {
-	defaultExcludePatterns, err := readJSONFile[[]types.ExcludePattern](filepath.Join("assets", "default-exclusions.json"))
+const exclusionTmpl = `{{- $tick := "` + "`" + `" -}}
+{{- range $name, $rules := . }}
+### {{ $tick }}{{ $name }}{{ $tick }}
+{{ range $rule := $rules }}
+{{ $tick }}{{ range $linter := $rule.Linters }}{{ $linter }}{{ end }}{{ $tick }}:
+{{ if $rule.Path -}}
+- Path: {{ $tick }}{{ $rule.Path }}{{ $tick }}
+{{ end -}}
+{{ if $rule.PathExcept -}}
+- Path Except: {{ $tick }}{{ $rule.PathExcept }}{{ $tick }}
+{{ end -}}
+{{ if $rule.Text -}}
+- Text: {{ $tick }}{{ $rule.Text }}{{ $tick }}
+{{ end -}}
+{{ if $rule.Source -}}
+- Source: {{ $tick }}{{ $rule.Source }}{{ $tick }}
+{{ end -}}
+{{ end }}{{ end }}`
+
+func getExclusionPresets() (string, error) {
+	linterExclusionPresets, err := readJSONFile[map[string][]types.ExcludeRule](filepath.Join("assets", "exclusion-presets.json"))
 	if err != nil {
 		return "", err
 	}
@@ -30,18 +40,9 @@ func getDefaultExclusions() (string, error) {
 		return "", err
 	}
 
-	for _, pattern := range defaultExcludePatterns {
-		data := map[string]any{
-			"ID":      pattern.ID,
-			"Linter":  pattern.Linter,
-			"Pattern": strings.ReplaceAll(pattern.Pattern, "`", "`"),
-			"Why":     pattern.Why,
-		}
-
-		err := tmpl.Execute(bufferString, data)
-		if err != nil {
-			return "", err
-		}
+	err = tmpl.Execute(bufferString, linterExclusionPresets)
+	if err != nil {
+		return "", err
 	}
 
 	return bufferString.String(), nil

pkg/lint/lintersdb/builder_linter.go

@@ -115,7 +115,7 @@ func buildTemplateContext() (map[string]string, error) {
 		return nil, fmt.Errorf("get the latest version: %w", err)
 	}
 
-	exclusions, err := getDefaultExclusions()
+	exclusions, err := getExclusionPresets()
 	if err != nil {
 		return nil, fmt.Errorf("default exclusions: %w", err)
 	}
@@ -127,7 +127,7 @@ func buildTemplateContext() (map[string]string, error) {
 		"LintersCommandOutputEnabledOnly": helps.Enable,
 		"EnabledByDefaultLinters":         getLintersListMarkdown(true),
 		"DisabledByDefaultLinters":        getLintersListMarkdown(false),
-		"DefaultExclusions":               exclusions,
+		"ExclusionPresets":                exclusions,
 		"ThanksList":                      getThanksList(),
 		"RunHelpText":                     helps.Help,
 		"ChangeLog":                       string(changeLog),