Fixing linter issues

Author: viktorasm

pkg/printers/github.go

@@ -3,6 +3,7 @@ package printers
 import (
 	"context"
 	"fmt"
+
 	"github.com/golangci/golangci-lint/pkg/logutils"
 	"github.com/golangci/golangci-lint/pkg/result"
 )
@@ -17,19 +18,19 @@ func NewGithub() Printer {
 }
 
 // print each line as: ::error file=app.js,line=10,col=15::Something went wrong
-func formatIssueAsGithub(issue result.Issue) string {
-	result := fmt.Sprintf("::error file=%s,line=%d", issue.FilePath(), issue.Line())
+func formatIssueAsGithub(issue *result.Issue) string {
+	ret := fmt.Sprintf("::error file=%s,line=%d", issue.FilePath(), issue.Line())
 	if issue.Pos.Column != 0 {
-		result += fmt.Sprintf(",col=%d", issue.Pos.Column)
+		ret += fmt.Sprintf(",col=%d", issue.Pos.Column)
 	}
 
-	result += fmt.Sprintf("::%s (%s)", issue.Text, issue.FromLinter)
-	return result
+	ret += fmt.Sprintf("::%s (%s)", issue.Text, issue.FromLinter)
+	return ret
 }
 
 func (g *github) Print(ctx context.Context, issues []result.Issue) error {
 	for _, issue := range issues {
-		_, err := fmt.Fprintln(logutils.StdOut, formatIssueAsGithub(issue))
+		_, err := fmt.Fprintln(logutils.StdOut, formatIssueAsGithub(&issue))
 		if err != nil {
 			return err
 		}

pkg/printers/github_test.go

@@ -1,10 +1,12 @@
 package printers
 
 import (
-	"github.com/golangci/golangci-lint/pkg/result"
-	"github.com/stretchr/testify/require"
 	"go/token"
 	"testing"
+
+	"github.com/stretchr/testify/require"
+
+	"github.com/golangci/golangci-lint/pkg/result"
 )
 
 func TestFormatGithubIssue(t *testing.T) {
@@ -18,8 +20,8 @@ func TestFormatGithubIssue(t *testing.T) {
 			Column:   4,
 		},
 	}
-	require.Equal(t, "::error file=path/to/file.go,line=10,col=4::some issue (sample-linter)", formatIssueAsGithub(sampleIssue))
+	require.Equal(t, "::error file=path/to/file.go,line=10,col=4::some issue (sample-linter)", formatIssueAsGithub(&sampleIssue))
 
 	sampleIssue.Pos.Column = 0
-	require.Equal(t, "::error file=path/to/file.go,line=10::some issue (sample-linter)", formatIssueAsGithub(sampleIssue))
+	require.Equal(t, "::error file=path/to/file.go,line=10::some issue (sample-linter)", formatIssueAsGithub(&sampleIssue))
 }