chore: groups unparam files to a package

Author: ldez

test/testdata/unparam.go renamed to pkg/golinters/unparam/testdata/unparam.go

@@ -1,4 +1,4 @@
-package golinters
+package unparam
 
 import (
 	"sync"
@@ -14,14 +14,14 @@ import (
 	"github.com/golangci/golangci-lint/pkg/result"
 )
 
-const unparamName = "unparam"
+const name = "unparam"
 
-func NewUnparam(settings *config.UnparamSettings) *goanalysis.Linter {
+func New(settings *config.UnparamSettings) *goanalysis.Linter {
 	var mu sync.Mutex
 	var resIssues []goanalysis.Issue
 
 	analyzer := &analysis.Analyzer{
-		Name:     unparamName,
+		Name:     name,
 		Doc:      goanalysis.TheOnlyanalyzerDoc,
 		Requires: []*analysis.Analyzer{buildssa.Analyzer},
 		Run: func(pass *analysis.Pass) (any, error) {
@@ -43,7 +43,7 @@ func NewUnparam(settings *config.UnparamSettings) *goanalysis.Linter {
 	}
 
 	return goanalysis.NewLinter(
-		unparamName,
+		name,
 		"Reports unused function parameters",
 		[]*analysis.Analyzer{analyzer},
 		nil,
@@ -82,7 +82,7 @@ func runUnparam(pass *analysis.Pass, settings *config.UnparamSettings) ([]goanal
 		issues = append(issues, goanalysis.NewIssue(&result.Issue{
 			Pos:        pass.Fset.Position(i.Pos()),
 			Text:       i.Message(),
-			FromLinter: unparamName,
+			FromLinter: name,
 		}, pass))
 	}
 

pkg/golinters/unparam.go renamed to pkg/golinters/unparam/unparam.go

@@ -0,0 +1,11 @@
+package unparam
+
+import (
+	"testing"
+
+	"github.com/golangci/golangci-lint/test/testshared/integration"
+)
+
+func TestFromTestdata(t *testing.T) {
+	integration.RunTestdata(t)
+}

pkg/golinters/unparam/unparam_integration_test.go

@@ -100,6 +100,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/golinters/thelper"
 	"github.com/golangci/golangci-lint/pkg/golinters/tparallel"
 	"github.com/golangci/golangci-lint/pkg/golinters/unconvert"
+	"github.com/golangci/golangci-lint/pkg/golinters/unparam"
 	"github.com/golangci/golangci-lint/pkg/golinters/whitespace"
 	"github.com/golangci/golangci-lint/pkg/golinters/zerologlint"
 	"github.com/golangci/golangci-lint/pkg/lint/linter"
@@ -755,7 +756,7 @@ func (LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/mdempsky/unconvert"),
 
-		linter.NewConfig(golinters.NewUnparam(&cfg.LintersSettings.Unparam)).
+		linter.NewConfig(unparam.New(&cfg.LintersSettings.Unparam)).
 			WithSince("v1.9.0").
 			WithPresets(linter.PresetUnused).
 			WithLoadForGoAnalysis().