Skip to content

Commit e09af97

Browse files
committed
Add ForceTypeAssert linter
1 parent 05836e4 commit e09af97

File tree

5 files changed

+47
-0
lines changed

5 files changed

+47
-0
lines changed

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ require (
3131
github.com/golangci/revgrep v0.0.0-20210208091834-cd28932614b5
3232
github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
3333
github.com/gordonklaus/ineffassign v0.0.0-20210225214923-2e10b2664254
34+
github.com/gostaticanalysis/forcetypeassert v0.0.0-20200621232751-01d4955beaa5
3435
github.com/jgautheron/goconst v1.4.0
3536
github.com/jingyugao/rowserrcheck v0.0.0-20210130005344-c6a0c12dd98d
3637
github.com/jirfag/go-printf-func-name v0.0.0-20191110105641-45db9963cdd3

go.sum

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/golinters/forcetypeassert.go

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
package golinters
2+
3+
import (
4+
"github.com/gostaticanalysis/forcetypeassert"
5+
"golang.org/x/tools/go/analysis"
6+
7+
"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
8+
)
9+
10+
func NewForceTypeAssert() *goanalysis.Linter {
11+
a := forcetypeassert.Analyzer
12+
13+
return goanalysis.NewLinter(
14+
a.Name,
15+
"finds forced type assertions",
16+
[]*analysis.Analyzer{a},
17+
nil,
18+
).WithLoadMode(goanalysis.LoadModeTypesInfo)
19+
}

pkg/lint/lintersdb/manager.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -386,6 +386,10 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
386386
WithPresets(linter.PresetStyle).
387387
WithLoadForGoAnalysis().
388388
WithURL("https://github.com/julz/importas"),
389+
linter.NewConfig(golinters.NewForceTypeAssert()).
390+
WithPresets(linter.PresetStyle).
391+
WithLoadForGoAnalysis().
392+
WithURL("https://github.com/gostaticanalysis/forcetypeassert"),
389393

390394
// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives
391395
linter.NewConfig(golinters.NewNoLintLint()).

test/testdata/forcetypeassert.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
//args: -Eforcetypeassert
2+
package testdata
3+
4+
import "fmt"
5+
6+
func forcetypeassertInvalid() {
7+
var a interface{}
8+
_ = a.(int) // ERROR "type assertion must be checked"
9+
10+
var b interface{}
11+
bi := b.(int) // ERROR "type assertion must be checked"
12+
fmt.Println(bi)
13+
}
14+
15+
func forcetypeassertValid() {
16+
var a interface{}
17+
if ai, ok := a.(int); ok {
18+
fmt.Println(ai)
19+
}
20+
}

0 commit comments

Comments
 (0)