|
| 1 | +// args: -Enonamedreturns |
| 2 | +// config: linters-settings.nonamedreturns.allow-error-in-defer=true |
| 3 | +package testdata |
| 4 | + |
| 5 | +func simple() (err error) { |
| 6 | + defer func() { |
| 7 | + err = nil |
| 8 | + }() |
| 9 | + return |
| 10 | +} |
| 11 | + |
| 12 | +func twoReturnParams() (i int, err error) { // ERROR `named return "i" with type "int" found` |
| 13 | + defer func() { |
| 14 | + i = 0 |
| 15 | + err = nil |
| 16 | + }() |
| 17 | + return |
| 18 | +} |
| 19 | + |
| 20 | +func allUnderscoresExceptError() (_ int, err error) { |
| 21 | + defer func() { |
| 22 | + err = nil |
| 23 | + }() |
| 24 | + return |
| 25 | +} |
| 26 | + |
| 27 | +func customName() (myName error) { |
| 28 | + defer func() { |
| 29 | + myName = nil |
| 30 | + }() |
| 31 | + return |
| 32 | +} |
| 33 | + |
| 34 | +func errorIsNoAssigned() (err error) { // ERROR `named return "err" with type "error" found` |
| 35 | + defer func() { |
| 36 | + _ = err |
| 37 | + processError(err) |
| 38 | + if err == nil { |
| 39 | + } |
| 40 | + switch err { |
| 41 | + case nil: |
| 42 | + default: |
| 43 | + } |
| 44 | + }() |
| 45 | + return |
| 46 | +} |
| 47 | + |
| 48 | +func shadowVariable() (err error) { |
| 49 | + defer func() { |
| 50 | + err := 123 // linter doesn't understand that this is different variable (even if different type) (yet?) |
| 51 | + _ = err |
| 52 | + }() |
| 53 | + return |
| 54 | +} |
| 55 | + |
| 56 | +func shadowVariable2() (err error) { |
| 57 | + defer func() { |
| 58 | + a, err := doSomething() // linter doesn't understand that this is different variable (yet?) |
| 59 | + _ = a |
| 60 | + _ = err |
| 61 | + }() |
| 62 | + return |
| 63 | +} |
| 64 | + |
| 65 | +type myError = error // linter doesn't understand that this is the same type (yet?) |
| 66 | + |
| 67 | +func customType() (err myError) { // ERROR `named return "err" with type "myError" found` |
| 68 | + defer func() { |
| 69 | + err = nil |
| 70 | + }() |
| 71 | + return |
| 72 | +} |
| 73 | + |
| 74 | +func notTheLast() (err error, _ int) { |
| 75 | + defer func() { |
| 76 | + err = nil |
| 77 | + }() |
| 78 | + return |
| 79 | +} |
| 80 | + |
| 81 | +func twoErrorsCombined() (err1, err2 error) { |
| 82 | + defer func() { |
| 83 | + err1 = nil |
| 84 | + err2 = nil |
| 85 | + }() |
| 86 | + return |
| 87 | +} |
| 88 | + |
| 89 | +func twoErrorsSeparated() (err1 error, err2 error) { |
| 90 | + defer func() { |
| 91 | + err1 = nil |
| 92 | + err2 = nil |
| 93 | + }() |
| 94 | + return |
| 95 | +} |
| 96 | + |
| 97 | +func errorSlice() (err []error) { // ERROR `named return "err" with type "\[\]error" found` |
| 98 | + defer func() { |
| 99 | + err = nil |
| 100 | + }() |
| 101 | + return |
| 102 | +} |
| 103 | + |
| 104 | +func deferWithVariable() (err error) { // ERROR `named return "err" with type "error" found` |
| 105 | + f := func() { |
| 106 | + err = nil |
| 107 | + } |
| 108 | + defer f() // linter can't catch closure passed via variable (yet?) |
| 109 | + return |
| 110 | +} |
| 111 | + |
| 112 | +func uberMultierr() (err error) { // ERROR `named return "err" with type "error" found` |
| 113 | + defer func() { |
| 114 | + multierrAppendInto(&err, nil) // linter doesn't allow it (yet?) |
| 115 | + }() |
| 116 | + return |
| 117 | +} |
| 118 | + |
| 119 | +func deferInDefer() (err error) { |
| 120 | + defer func() { |
| 121 | + defer func() { |
| 122 | + err = nil |
| 123 | + }() |
| 124 | + }() |
| 125 | + return |
| 126 | +} |
| 127 | + |
| 128 | +func twoDefers() (err error) { |
| 129 | + defer func() {}() |
| 130 | + defer func() { |
| 131 | + err = nil |
| 132 | + }() |
| 133 | + return |
| 134 | +} |
| 135 | + |
| 136 | +func callFunction() (err error) { |
| 137 | + defer func() { |
| 138 | + _, err = doSomething() |
| 139 | + }() |
| 140 | + return |
| 141 | +} |
| 142 | + |
| 143 | +func callFunction2() (err error) { |
| 144 | + defer func() { |
| 145 | + var a int |
| 146 | + a, err = doSomething() |
| 147 | + _ = a |
| 148 | + }() |
| 149 | + return |
| 150 | +} |
| 151 | + |
| 152 | +func deepInside() (err error) { |
| 153 | + if true { |
| 154 | + switch true { |
| 155 | + case false: |
| 156 | + for i := 0; i < 10; i++ { |
| 157 | + go func() { |
| 158 | + select { |
| 159 | + default: |
| 160 | + defer func() { |
| 161 | + if true { |
| 162 | + switch true { |
| 163 | + case false: |
| 164 | + for j := 0; j < 10; j++ { |
| 165 | + go func() { |
| 166 | + select { |
| 167 | + default: |
| 168 | + err = nil |
| 169 | + } |
| 170 | + }() |
| 171 | + } |
| 172 | + } |
| 173 | + } |
| 174 | + }() |
| 175 | + } |
| 176 | + }() |
| 177 | + } |
| 178 | + } |
| 179 | + } |
| 180 | + return |
| 181 | +} |
| 182 | + |
| 183 | +var goodFuncLiteral = func() (err error) { |
| 184 | + defer func() { |
| 185 | + err = nil |
| 186 | + }() |
| 187 | + return |
| 188 | +} |
| 189 | + |
| 190 | +var badFuncLiteral = func() (err error) { // ERROR `named return "err" with type "error" found` |
| 191 | + defer func() { |
| 192 | + _ = err |
| 193 | + }() |
| 194 | + return |
| 195 | +} |
| 196 | + |
| 197 | +func funcLiteralInsideFunc() error { |
| 198 | + do := func() (err error) { |
| 199 | + defer func() { |
| 200 | + err = nil |
| 201 | + }() |
| 202 | + return |
| 203 | + } |
| 204 | + return do() |
| 205 | +} |
| 206 | + |
| 207 | +type x struct{} |
| 208 | + |
| 209 | +func (x) goodMethod() (err error) { |
| 210 | + defer func() { |
| 211 | + err = nil |
| 212 | + }() |
| 213 | + return |
| 214 | +} |
| 215 | + |
| 216 | +func (x) badMethod() (err error) { // ERROR `named return "err" with type "error" found` |
| 217 | + defer func() { |
| 218 | + _ = err |
| 219 | + }() |
| 220 | + return |
| 221 | +} |
| 222 | + |
| 223 | +func processError(error) {} |
| 224 | +func doSomething() (int, error) { return 10, nil } |
| 225 | +func multierrAppendInto(*error, error) bool { return false } // https://pkg.go.dev/go.uber.org/multierr#AppendInto |
0 commit comments