fix: exit early on run --version (#3067)

ldez · web-flow · commit da3b1496896e · 2022-08-05T15:49:22.000+02:00
diff --git a/pkg/commands/root.go b/pkg/commands/root.go
@@ -12,13 +12,14 @@ import (
 	"github.com/spf13/pflag"
 
 	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/exitcodes"
 	"github.com/golangci/golangci-lint/pkg/logutils"
 )
 
 func (e *Executor) persistentPreRun(_ *cobra.Command, _ []string) error {
 	if e.cfg.Run.PrintVersion {
 		_, _ = fmt.Fprintf(logutils.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date)
-		return nil
+		os.Exit(exitcodes.Success) // a return nil is not enough to stop the process because we are inside the `preRun`.
 	}
 
 	runtime.GOMAXPROCS(e.cfg.Run.Concurrency)

Original file line number	Diff line number	Diff line change
`@@ -12,13 +12,14 @@ import (`
`12`	`12`	`"github.com/spf13/pflag"`
`13`	`13`
`14`	`14`	`"github.com/golangci/golangci-lint/pkg/config"`
	`15`	`+ "github.com/golangci/golangci-lint/pkg/exitcodes"`
`15`	`16`	`"github.com/golangci/golangci-lint/pkg/logutils"`
`16`	`17`	`)`
`17`	`18`
`18`	`19`	`func (e Executor) persistentPreRun(_ cobra.Command, _ []string) error {`
`19`	`20`	`if e.cfg.Run.PrintVersion {`
`20`	`21`	`_, _ = fmt.Fprintf(logutils.StdOut, "golangci-lint has version %s built from %s on %s\n", e.version, e.commit, e.date)`
`21`		`- return nil`
	`22`	+ os.Exit(exitcodes.Success) // a return nil is not enough to stop the process because we are inside the `preRun`.
`22`	`23`	`}`
`23`	`24`
`24`	`25`	`runtime.GOMAXPROCS(e.cfg.Run.Concurrency)`