feat: add gocheckcompilerdirectives (#3463)

Author: leighmcculloch

.golangci.reference.yml

@@ -2014,6 +2014,7 @@ linters:
     - funlen
     - gci
     - ginkgolinter
+    - gocheckcompilerdirectives
     - gochecknoglobals
     - gochecknoinits
     - gocognit
@@ -2123,6 +2124,7 @@ linters:
     - funlen
     - gci
     - ginkgolinter
+    - gocheckcompilerdirectives
     - gochecknoglobals
     - gochecknoinits
     - gocognit

go.mod

@@ -3,6 +3,7 @@ module github.com/golangci/golangci-lint
 go 1.19
 
 require (
+	4d63.com/gocheckcompilerdirectives v1.1.0
 	4d63.com/gochecknoglobals v0.1.0
 	github.com/Abirdcfly/dupword v0.0.9
 	github.com/Antonboom/errname v0.1.7

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"4d63.com/gocheckcompilerdirectives/checkcompilerdirectives"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewGoCheckCompilerDirectives() *goanalysis.Linter {
+	a := checkcompilerdirectives.Analyzer()
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/gocheckcompilerdirectives.go

@@ -440,6 +440,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/nunnatsa/ginkgolinter"),
 
+		linter.NewConfig(golinters.NewGoCheckCompilerDirectives()).
+			WithSince("v1.51.0").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/leighmcculloch/gocheckcompilerdirectives"),
+
 		linter.NewConfig(golinters.NewGochecknoglobals()).
 			WithSince("v1.12.0").
 			WithPresets(linter.PresetStyle).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,21 @@
+//golangcitest:args -Egocheckcompilerdirectives
+package testdata
+
+import _ "embed"
+
+// Okay cases:
+
+//go:generate echo hello world
+
+//go:embed
+var Value string
+
+//go:
+
+// Problematic cases:
+
+// go:embed // want "compiler directive contains space: // go:embed"
+
+//    go:embed // want "compiler directive contains space: //    go:embed"
+
+//go:genrate // want "compiler directive unrecognized: //go:genrate"