Implement auto-fixing for gofmt,goimports,misspell

Also, add more identifier marking patterns.

Author: jirfag

.golangci.yml

@@ -43,15 +43,15 @@ run:
   skip-dirs:
     - test/testdata_etc
 
+issues:
+  exclude-rules:
+    - text: "weak cryptographic primitive"
+      linters:
+        - gosec
+
 # golangci.com configuration
 # https://github.com/golangci/golangci/wiki/Configuration
 service:
-  golangci-lint-version: 1.13.x # use fixed version to not introduce new linters unexpectedly
+  golangci-lint-version: 1.14.x # use the fixed version to not introduce new linters unexpectedly
   prepare:
     - echo "here I can run custom commands, but no preparation needed"
-
-issues:
-  exclude-rules:
-    - text: "weak cryptographic primitive"
-      linters:
-        - gosec

README.md

@@ -185,16 +185,16 @@ GolangCI-Lint can be used with zero configuration. By default the following lint
 ```bash
 $ golangci-lint help linters
 Enabled by default linters:
-govet (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true]
-errcheck: Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: true]
-staticcheck: Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: false]
-unused: Checks Go code for unused constants, variables, functions and types [fast: false]
-gosimple: Linter for Go source code that specializes in simplifying a code [fast: false]
-structcheck: Finds an unused struct fields [fast: true]
-varcheck: Finds unused global variables and constants [fast: true]
-ineffassign: Detects when assignments to existing variables are not used [fast: true]
-deadcode: Finds unused code [fast: true]
-typecheck: Like the front-end of a Go compiler, parses and type-checks Go code [fast: true]
+govet (vet, vetshadow): Vet examines Go source code and reports suspicious constructs, such as Printf calls whose arguments do not align with the format string [fast: true, auto-fix: false]
+errcheck: Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: true, auto-fix: false]
+staticcheck: Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: false, auto-fix: false]
+unused: Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
+gosimple: Linter for Go source code that specializes in simplifying a code [fast: false, auto-fix: false]
+structcheck: Finds an unused struct fields [fast: true, auto-fix: false]
+varcheck: Finds unused global variables and constants [fast: true, auto-fix: false]
+ineffassign: Detects when assignments to existing variables are not used [fast: true, auto-fix: false]
+deadcode: Finds unused code [fast: true, auto-fix: false]
+typecheck: Like the front-end of a Go compiler, parses and type-checks Go code [fast: true, auto-fix: false]
 ```
 
 and the following linters are disabled by default:
@@ -203,27 +203,27 @@ and the following linters are disabled by default:
 $ golangci-lint help linters
 ...
 Disabled by default linters:
-golint: Golint differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes [fast: true]
-stylecheck: Stylecheck is a replacement for golint [fast: false]
-gosec (gas): Inspects source code for security problems [fast: true]
-interfacer: Linter that suggests narrower interface types [fast: false]
-unconvert: Remove unnecessary type conversions [fast: true]
-dupl: Tool for code clone detection [fast: true]
-goconst: Finds repeated strings that could be replaced by a constant [fast: true]
-gocyclo: Computes and checks the cyclomatic complexity of functions [fast: true]
-gofmt: Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true]
-goimports: Goimports does everything that gofmt does. Additionally it checks unused imports [fast: true]
-maligned: Tool to detect Go structs that would take less memory if their fields were sorted [fast: true]
-depguard: Go linter that checks if package imports are in a list of acceptable packages [fast: true]
-misspell: Finds commonly misspelled English words in comments [fast: true]
-lll: Reports long lines [fast: true]
-unparam: Reports unused function parameters [fast: false]
-nakedret: Finds naked returns in functions greater than a specified function length [fast: true]
-prealloc: Finds slice declarations that could potentially be preallocated [fast: true]
-scopelint: Scopelint checks for unpinned variables in go programs [fast: true]
-gocritic: The most opinionated Go source code linter [fast: true]
-gochecknoinits: Checks that no init functions are present in Go code [fast: true]
-gochecknoglobals: Checks that no globals are present in Go code [fast: true]
+golint: Golint differs from gofmt. Gofmt reformats Go source code, whereas golint prints out style mistakes [fast: true, auto-fix: false]
+stylecheck: Stylecheck is a replacement for golint [fast: false, auto-fix: false]
+gosec (gas): Inspects source code for security problems [fast: true, auto-fix: false]
+interfacer: Linter that suggests narrower interface types [fast: false, auto-fix: false]
+unconvert: Remove unnecessary type conversions [fast: true, auto-fix: false]
+dupl: Tool for code clone detection [fast: true, auto-fix: false]
+goconst: Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
+gocyclo: Computes and checks the cyclomatic complexity of functions [fast: true, auto-fix: false]
+gofmt: Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
+goimports: Goimports does everything that gofmt does. Additionally it checks unused imports [fast: true, auto-fix: true]
+maligned: Tool to detect Go structs that would take less memory if their fields were sorted [fast: true, auto-fix: false]
+depguard: Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
+misspell: Finds commonly misspelled English words in comments [fast: true, auto-fix: true]
+lll: Reports long lines [fast: true, auto-fix: false]
+unparam: Reports unused function parameters [fast: false, auto-fix: false]
+nakedret: Finds naked returns in functions greater than a specified function length [fast: true, auto-fix: false]
+prealloc: Finds slice declarations that could potentially be preallocated [fast: true, auto-fix: false]
+scopelint: Scopelint checks for unpinned variables in go programs [fast: true, auto-fix: false]
+gocritic: The most opinionated Go source code linter [fast: true, auto-fix: false]
+gochecknoinits: Checks that no init functions are present in Go code [fast: true, auto-fix: false]
+gochecknoglobals: Checks that no globals are present in Go code [fast: true, auto-fix: false]
 ```
 
 Pass `-E/--enable` to enable linter and `-D/--disable` to disable:
@@ -499,6 +499,7 @@ Flags:
                                     For CI setups, prefer --new-from-rev=HEAD~, as --new can skip linting the current patch if any scripts generate unstaged files before golangci-lint runs.
       --new-from-rev REV            Show only new issues created after git revision REV
       --new-from-patch PATH         Show only new issues created in git patch with file path PATH
+      --fix                         Fix found issues (if it's supported by the linter)
   -h, --help                        help for run
 
 Global Flags:
@@ -829,18 +830,18 @@ run:
   skip-dirs:
     - test/testdata_etc
 
-# golangci.com configuration
-# https://github.com/golangci/golangci/wiki/Configuration
-service:
-  golangci-lint-version: 1.13.x # use fixed version to not introduce new linters unexpectedly
-  prepare:
-    - echo "here I can run custom commands, but no preparation needed"
-
 issues:
   exclude-rules:
     - text: "weak cryptographic primitive"
       linters:
         - gosec
+
+# golangci.com configuration
+# https://github.com/golangci/golangci/wiki/Configuration
+service:
+  golangci-lint-version: 1.14.x # use the fixed version to not introduce new linters unexpectedly
+  prepare:
+    - echo "here I can run custom commands, but no preparation needed"
 ```
 
 ## False Positives

pkg/commands/help.go

@@ -41,8 +41,8 @@ func printLinterConfigs(lcs []*linter.Config) {
 		if len(lc.AlternativeNames) != 0 {
 			altNamesStr = fmt.Sprintf(" (%s)", strings.Join(lc.AlternativeNames, ", "))
 		}
-		fmt.Fprintf(logutils.StdOut, "%s%s: %s [fast: %t]\n", color.YellowString(lc.Name()),
-			altNamesStr, lc.Linter.Desc(), !lc.NeedsSSARepr)
+		fmt.Fprintf(logutils.StdOut, "%s%s: %s [fast: %t, auto-fix: %t]\n", color.YellowString(lc.Name()),
+			altNamesStr, lc.Linter.Desc(), !lc.NeedsSSARepr, lc.CanAutoFix)
 	}
 }
 

pkg/commands/run.go

@@ -10,6 +10,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/golangci/golangci-lint/pkg/result/processors"
+
 	"github.com/fatih/color"
 	"github.com/pkg/errors"
 	"github.com/spf13/cobra"
@@ -177,7 +179,7 @@ func initFlagSet(fs *pflag.FlagSet, cfg *config.Config, m *lintersdb.Manager, is
 		wh("Show only new issues created after git revision `REV`"))
 	fs.StringVar(&ic.DiffPatchFilePath, "new-from-patch", "",
 		wh("Show only new issues created in git patch with file path `PATH`"))
-
+	fs.BoolVar(&ic.NeedFix, "fix", false, "Fix found issues (if it's supported by the linter)")
 }
 
 func (e *Executor) initRunConfiguration(cmd *cobra.Command) {
@@ -281,7 +283,9 @@ func (e *Executor) runAnalysis(ctx context.Context, args []string) (<-chan resul
 		return nil, err
 	}
 
-	return runner.Run(ctx, enabledLinters, lintCtx), nil
+	issuesCh := runner.Run(ctx, enabledLinters, lintCtx)
+	fixer := processors.NewFixer(e.cfg, e.log)
+	return fixer.Process(issuesCh), nil
 }
 
 func (e *Executor) setOutputToDevNull() (savedStdout, savedStderr *os.File) {

pkg/config/config.go

@@ -278,6 +278,8 @@ type Issues struct {
 	DiffFromRevision  string `mapstructure:"new-from-rev"`
 	DiffPatchFilePath string `mapstructure:"new-from-patch"`
 	Diff              bool   `mapstructure:"new"`
+
+	NeedFix bool `mapstructure:"fix"`
 }
 
 type Config struct { //nolint:maligned