Skip to content

Commit cec6581

Browse files
alexandearldez
andauthored
docs: improve grammar of new linter checklist (#4861)
Co-authored-by: Fernandez Ludovic <[email protected]>
1 parent 1d23948 commit cec6581

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/new-linter-checklist.md

+6-6
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@ In order for a pull request adding a linter to be reviewed, the linter and the P
99

1010
### Linter
1111

12-
- [ ] It must not be a duplicate of another linter or a rule of a linter. (the team will help to verify that)
13-
- [ ] It must have a valid license (AGPL is not allowed) and the file must contain the required information by the license, ex: author, year, etc.
14-
- [ ] It must use Go <= 1.21
12+
- [ ] It must not be a duplicate of another linter or a rule of a linter (the team will help to verify that).
13+
- [ ] It must have a valid license (AGPL is not allowed), and the file must contain the required information by the license, ex: author, year, etc.
14+
- [ ] It must use Go version >= 1.21
1515
- [ ] The linter repository must have a CI and tests.
1616
- [ ] It must use [`go/analysis`](https://golangci-lint.run/contributing/new-linters/).
1717
- [ ] It must have a valid tag, ex: `v1.0.0`, `v0.1.0`.
1818
- [ ] It must not contain `init()`.
1919
- [ ] It must not contain `panic()`.
20-
- [ ] It must not contain `log.fatal()`, `os.exit()`, or similar.
20+
- [ ] It must not contain `log.Fatal()`, `os.Exit()`, or similar.
2121
- [ ] It must not modify the AST.
22-
- [ ] It must not have false positives/negatives. (the team will help to verify that)
22+
- [ ] It must not have false positives/negatives (the team will help to verify that).
2323
- [ ] It must have tests inside golangci-lint.
2424

2525
### The Linter Tests Inside Golangci-lint
@@ -55,7 +55,7 @@ In order for a pull request adding a linter to be reviewed, the linter and the P
5555
- [ ] The file `jsonschema/golangci.next.jsonschema.json` should be updated.
5656
- [ ] The file `jsonschema/golangci.jsonschema.json` must NOT be edited.
5757
- [ ] The linter repository should have a readme and linting.
58-
- [ ] The linter should be published as a binary. (useful to diagnose bug origins)
58+
- [ ] The linter should be published as a binary (useful to diagnose bug origins).
5959
- [ ] The linter repository should have a `.gitignore` (IDE files, binaries, OS files, etc. should not be committed)
6060
- [ ] A tag should never be recreated.
6161

0 commit comments

Comments
 (0)