Skip to content

Commit cd9d8bb

Browse files
authored
govet: Update vet passes (#1950)
1 parent 7f1fa3b commit cd9d8bb

File tree

3 files changed

+20
-5
lines changed

3 files changed

+20
-5
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ require (
8282
github.com/uudashr/gocognit v1.0.1
8383
github.com/valyala/quicktemplate v1.6.3
8484
github.com/yeya24/promlinter v0.1.0
85-
golang.org/x/tools v0.1.0
85+
golang.org/x/tools v0.1.1-0.20210430200834-7a6108e9b210
8686
gopkg.in/yaml.v2 v2.4.0
8787
honnef.co/go/tools v0.1.3
8888
mvdan.cc/gofumpt v0.1.1

go.sum

Lines changed: 11 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/golinters/govet.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,10 @@ import (
2727
"golang.org/x/tools/go/analysis/passes/nilness"
2828
_ "golang.org/x/tools/go/analysis/passes/pkgfact" // unused, internal analyzer
2929
"golang.org/x/tools/go/analysis/passes/printf"
30+
"golang.org/x/tools/go/analysis/passes/reflectvaluecompare"
3031
"golang.org/x/tools/go/analysis/passes/shadow"
3132
"golang.org/x/tools/go/analysis/passes/shift"
33+
"golang.org/x/tools/go/analysis/passes/sigchanyzer"
3234
"golang.org/x/tools/go/analysis/passes/sortslice"
3335
"golang.org/x/tools/go/analysis/passes/stdmethods"
3436
"golang.org/x/tools/go/analysis/passes/stringintconv"
@@ -39,6 +41,7 @@ import (
3941
"golang.org/x/tools/go/analysis/passes/unreachable"
4042
"golang.org/x/tools/go/analysis/passes/unsafeptr"
4143
"golang.org/x/tools/go/analysis/passes/unusedresult"
44+
"golang.org/x/tools/go/analysis/passes/unusedwrite"
4245

4346
"github.com/golangci/golangci-lint/pkg/config"
4447
"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
@@ -67,8 +70,10 @@ var (
6770
nilfunc.Analyzer,
6871
nilness.Analyzer,
6972
printf.Analyzer,
73+
reflectvaluecompare.Analyzer,
7074
shadow.Analyzer,
7175
shift.Analyzer,
76+
sigchanyzer.Analyzer,
7277
sortslice.Analyzer,
7378
stdmethods.Analyzer,
7479
stringintconv.Analyzer,
@@ -79,8 +84,10 @@ var (
7984
unreachable.Analyzer,
8085
unsafeptr.Analyzer,
8186
unusedresult.Analyzer,
87+
unusedwrite.Analyzer,
8288
}
8389

90+
// https://github.com/golang/go/blob/879db69ce2de814bc3203c39b45617ba51cc5366/src/cmd/vet/main.go#L40-L68
8491
defaultAnalyzers = []*analysis.Analyzer{
8592
asmdecl.Analyzer,
8693
assign.Analyzer,
@@ -99,6 +106,7 @@ var (
99106
nilfunc.Analyzer,
100107
printf.Analyzer,
101108
shift.Analyzer,
109+
sigchanyzer.Analyzer,
102110
stdmethods.Analyzer,
103111
stringintconv.Analyzer,
104112
structtag.Analyzer,

0 commit comments

Comments
 (0)