feat: remove typecheck from the linter list

Author: ldez

pkg/commands/help.go

@@ -63,6 +63,10 @@ func printLinterConfigs(lcs []*linter.Config) {
 func (e *Executor) executeLintersHelp(_ *cobra.Command, _ []string) {
 	var enabledLCs, disabledLCs []*linter.Config
 	for _, lc := range e.DBManager.GetAllSupportedLinterConfigs() {
+		if lc.Internal {
+			continue
+		}
+
 		if lc.EnabledByDefault {
 			enabledLCs = append(enabledLCs, lc)
 		} else {
@@ -78,8 +82,12 @@ func (e *Executor) executeLintersHelp(_ *cobra.Command, _ []string) {
 	color.Green("\nLinters presets:")
 	for _, p := range e.DBManager.AllPresets() {
 		linters := e.DBManager.GetAllLinterConfigsForPreset(p)
-		linterNames := make([]string, 0, len(linters))
+		var linterNames []string
 		for _, lc := range linters {
+			if lc.Internal {
+				continue
+			}
+
 			linterNames = append(linterNames, lc.Name())
 		}
 		sort.Strings(linterNames)

pkg/commands/linters.go

@@ -29,14 +29,22 @@ func (e *Executor) executeLinters(_ *cobra.Command, _ []string) error {
 	}
 
 	color.Green("Enabled by your configuration linters:\n")
-	enabledLinters := make([]*linter.Config, 0, len(enabledLintersMap))
-	for _, linter := range enabledLintersMap {
-		enabledLinters = append(enabledLinters, linter)
+	var enabledLinters []*linter.Config
+	for _, lc := range enabledLintersMap {
+		if lc.Internal {
+			continue
+		}
+
+		enabledLinters = append(enabledLinters, lc)
 	}
 	printLinterConfigs(enabledLinters)
 
 	var disabledLCs []*linter.Config
 	for _, lc := range e.DBManager.GetAllSupportedLinterConfigs() {
+		if lc.Internal {
+			continue
+		}
+
 		if enabledLintersMap[lc.Name()] == nil {
 			disabledLCs = append(disabledLCs, lc)
 		}

pkg/lint/linter/config.go

@@ -42,6 +42,7 @@ type Config struct {
 	AlternativeNames []string
 
 	OriginalURL     string // URL of original (not forked) repo, needed for autogenerated README
+	Internal        bool   // Internal linters cannot be disabled (ex: typecheck).
 	CanAutoFix      bool
 	IsSlow          bool
 	DoesChangeTypes bool
@@ -55,6 +56,11 @@ func (lc *Config) WithEnabledByDefault() *Config {
 	return lc
 }
 
+func (lc *Config) WithInternal() *Config {
+	lc.Internal = true
+	return lc
+}
+
 func (lc *Config) ConsiderSlow() *Config {
 	lc.IsSlow = true
 	return lc

pkg/lint/lintersdb/enabled_set.go

@@ -33,6 +33,7 @@ func NewEnabledSet(m *Manager, v *Validator, log logutils.Log, cfg *config.Confi
 
 func (es EnabledSet) build(lcfg *config.Linters, enabledByDefaultLinters []*linter.Config) map[string]*linter.Config {
 	es.debugf("Linters config: %#v", lcfg)
+
 	resultLintersSet := map[string]*linter.Config{}
 	switch {
 	case len(lcfg.Presets) != 0:
@@ -78,6 +79,14 @@ func (es EnabledSet) build(lcfg *config.Linters, enabledByDefaultLinters []*lint
 		}
 	}
 
+	// typecheck is not a real linter and cannot be disabled.
+	if _, ok := resultLintersSet["typecheck"]; !ok {
+		for _, lc := range es.m.GetLinterConfigs("typecheck") {
+			// it's important to use lc.Name() nor name because name can be alias
+			resultLintersSet[lc.Name()] = lc
+		}
+	}
+
 	return resultLintersSet
 }
 

pkg/lint/lintersdb/manager.go

@@ -804,6 +804,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithURL("https://github.com/moricho/tparallel"),
 
 		linter.NewConfig(golinters.NewTypecheck()).
+			WithInternal().
 			WithEnabledByDefault().
 			WithSince("v1.3.0").
 			WithLoadForGoAnalysis().

scripts/expand_website_templates/main.go

@@ -238,6 +238,10 @@ func getLintersListMarkdown(enabled bool) string {
 	var neededLcs []*linter.Config
 	lcs := lintersdb.NewManager(nil, nil).GetAllSupportedLinterConfigs()
 	for _, lc := range lcs {
+		if lc.Internal {
+			continue
+		}
+
 		if lc.EnabledByDefault == enabled {
 			neededLcs = append(neededLcs, lc)
 		}