review: disable timeout by default

Author: ldez

.golangci.next.reference.yml

@@ -4131,7 +4131,7 @@ output:
 run:
   # Timeout for analysis, e.g. 30s, 5m.
   # If the value is lower or equal to 0, the timeout is disabled.
-  # Default: 15m
+  # Default: 0 (disabled)
   timeout: 5m
 
   # The mode used to evaluate relative paths.

.golangci.yml

@@ -202,5 +202,3 @@ linters-settings:
       - name: unused-parameter
       - name: unused-receiver
 
-run:
-  timeout: 5m

jsonschema/golangci.next.jsonschema.json

@@ -3744,10 +3744,10 @@
           "examples": [4]
         },
         "timeout": {
-          "description": "Timeout for the analysis.",
+          "description": "Timeout for total work. Disabled by default",
           "type": "string",
           "pattern": "^\\d*[sm]$",
-          "default": "1m",
+          "default": "0",
           "examples": ["30s", "5m"]
         },
         "issues-exit-code": {

pkg/commands/flagsets.go

@@ -53,7 +53,7 @@ func setupRunFlagSet(v *viper.Viper, fs *pflag.FlagSet) {
 	internal.AddHackedStringSlice(fs, "build-tags", color.GreenString("Build tags"))
 
 	internal.AddFlagAndBind(v, fs, fs.Duration, "timeout", "run.timeout", defaultTimeout,
-		color.GreenString("Timeout for total work. If <= 0, the timeout is disabled"))
+		color.GreenString("Timeout for total work. Disabled by default"))
 
 	internal.AddFlagAndBind(v, fs, fs.Bool, "tests", "run.tests", true, color.GreenString("Analyze tests (*_test.go)"))
 

pkg/commands/run.go

@@ -43,7 +43,7 @@ import (
 	"github.com/golangci/golangci-lint/pkg/timeutils"
 )
 
-const defaultTimeout = 15 * time.Minute
+const defaultTimeout = 0 * time.Minute
 
 const (
 	// envFailOnWarnings value: "1"