Skip to content

Commit b6164b8

Browse files
committed
chore: update tests
1 parent 8db6715 commit b6164b8

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

pkg/golinters/ginkgolinter/testdata/ginkgolinter_suppress_compare.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ func WrongComparisonUsecase_compare() {
6464
x := 8
6565
Expect(x == 8).To(BeTrue())
6666
Expect(x < 9).To(BeTrue())
67-
Expect(x < 7).To(Equal(false))
67+
Expect(x < 7).To(Equal(false)) // want "ginkgo-linter: wrong boolean assertion. Consider using `Expect\\(x < 7\\)\\.To\\(BeFalse\\(\\)\\)`"
6868

6969
p1, p2 := &x, &x
70-
Expect(p1 == p2).To(Equal(true))
70+
Expect(p1 == p2).To(Equal(true)) // want "ginkgo-linter: wrong boolean assertion. Consider using `Expect\\(p1 == p2\\)\\.To\\(BeTrue\\(\\)\\)`"
7171
}
7272

7373
func slowInt_compare() int {

pkg/golinters/ginkgolinter/testdata/ginkgolinter_suppress_err.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ func ErrorUsecase_err() {
4949
funcReturnsErr := func() error { return err }
5050

5151
Expect(err).To(BeNil())
52-
Expect(err == nil).To(Equal(true))
53-
Expect(err == nil).To(BeFalse())
54-
Expect(err != nil).To(BeTrue())
52+
Expect(err == nil).To(Equal(true)) // want "ginkgo-linter: wrong nil assertion. Consider using `Expect\\(err\\).To\\(BeNil\\(\\)\\)`"
53+
Expect(err == nil).To(BeFalse()) // want "ginkgo-linter: wrong nil assertion. Consider using `Expect\\(err\\).ToNot\\(BeNil\\(\\)\\)`"
54+
Expect(err != nil).To(BeTrue()) // want "ginkgo-linter: wrong nil assertion. Consider using `Expect\\(err\\).ToNot\\(BeNil\\(\\)\\)`"
5555
Expect(funcReturnsErr()).To(BeNil())
5656
}
5757

pkg/golinters/ginkgolinter/testdata/ginkgolinter_suppress_nil.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ func LenUsecase_nil() {
3131
func NilUsecase_nil() {
3232
y := 5
3333
x := &y
34-
Expect(x == nil).To(Equal(true))
35-
Expect(nil == x).To(Equal(true))
36-
Expect(x != nil).To(Equal(true))
34+
Expect(x == nil).To(Equal(true)) // want "ginkgo-linter: wrong boolean assertion. Consider using `Expect\\(x == nil\\).To\\(BeTrue\\(\\)\\)`"
35+
Expect(nil == x).To(Equal(true)) // want "ginkgo-linter: wrong boolean assertion. Consider using `Expect\\(nil == x\\).To\\(BeTrue\\(\\)\\)`"
36+
Expect(x != nil).To(Equal(true)) // want "ginkgo-linter: wrong boolean assertion. Consider using `Expect\\(x != nil\\).To\\(BeTrue\\(\\)\\)`"
3737
Expect(x == nil).To(BeTrue())
3838
Expect(x == nil).To(BeFalse())
3939
}

0 commit comments

Comments
 (0)