feat: early validation

Author: ldez

pkg/commands/linters.go

@@ -61,7 +61,7 @@ func newLintersCommand(logger logutils.Log) *lintersCommand {
 func (c *lintersCommand) preRunE(cmd *cobra.Command, args []string) error {
 	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, cmd.Flags(), c.opts.LoaderOptions, c.cfg, args)
 
-	err := loader.Load(config.LoadOptions{})
+	err := loader.Load(config.LoadOptions{Validation: true})
 	if err != nil {
 		return fmt.Errorf("can't load config: %w", err)
 	}

pkg/commands/run.go

@@ -154,7 +154,7 @@ func (c *runCommand) persistentPreRunE(cmd *cobra.Command, args []string) error
 
 	loader := config.NewLoader(c.log.Child(logutils.DebugKeyConfigReader), c.viper, cmd.Flags(), c.opts.LoaderOptions, c.cfg, args)
 
-	err := loader.Load(config.LoadOptions{CheckDeprecation: true})
+	err := loader.Load(config.LoadOptions{CheckDeprecation: true, Validation: true})
 	if err != nil {
 		return fmt.Errorf("can't load config: %w", err)
 	}

pkg/config/config.go

@@ -33,12 +33,12 @@ func (c *Config) GetConfigDir() string {
 
 func (c *Config) Validate() error {
 	validators := []func() error{
-		c.Issues.Validate,
-		c.Severity.Validate,
+		c.Run.Validate,
+		c.Output.Validate,
 		c.LintersSettings.Validate,
 		c.Linters.Validate,
-		c.Output.Validate,
-		c.Run.Validate,
+		c.Issues.Validate,
+		c.Severity.Validate,
 	}
 
 	for _, v := range validators {

pkg/config/loader.go

@@ -26,6 +26,7 @@ type LoaderOptions struct {
 
 type LoadOptions struct {
 	CheckDeprecation bool
+	Validation       bool
 }
 
 type Loader struct {
@@ -78,6 +79,13 @@ func (l *Loader) Load(opts LoadOptions) error {
 		return err
 	}
 
+	if opts.Validation {
+		err = l.cfg.Validate()
+		if err != nil {
+			return err
+		}
+	}
+
 	return nil
 }
 

pkg/lint/lintersdb/validator.go

@@ -22,11 +22,6 @@ func NewValidator(m *Manager) *Validator {
 // Validate validates the configuration by calling all other validators for different
 // sections in the configuration and then some additional linter validation functions.
 func (v Validator) Validate(cfg *config.Config) error {
-	err := cfg.Validate()
-	if err != nil {
-		return err
-	}
-
 	validators := []func(cfg *config.Linters) error{
 		v.validateLintersNames,
 		v.validatePresets,