Skip to content

Commit ab9d034

Browse files
committed
fix: err113 analyzer name
1 parent 66ec75e commit ab9d034

File tree

8 files changed

+33
-30
lines changed

8 files changed

+33
-30
lines changed

.golangci.next.reference.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2547,7 +2547,7 @@ linters:
25472547
- gocyclo
25482548
- godot
25492549
- godox
2550-
- goerr113
2550+
- err113
25512551
- gofmt
25522552
- gofumpt
25532553
- goheader
@@ -2660,7 +2660,7 @@ linters:
26602660
- gocyclo
26612661
- godot
26622662
- godox
2663-
- goerr113
2663+
- err113
26642664
- gofmt
26652665
- gofumpt
26662666
- goheader

jsonschema/golangci.next.jsonschema.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@
250250
"gocyclo",
251251
"godot",
252252
"godox",
253-
"goerr113",
253+
"err113",
254254
"gofmt",
255255
"gofumpt",
256256
"goheader",

pkg/golinters/goerr113.go renamed to pkg/golinters/err113.go

+5-3
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ import (
77
"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
88
)
99

10-
func NewGoerr113() *goanalysis.Linter {
10+
func NewErr113() *goanalysis.Linter {
11+
a := err113.NewAnalyzer()
12+
1113
return goanalysis.NewLinter(
12-
"goerr113",
14+
a.Name,
1315
"Go linter to check the errors handling expressions",
14-
[]*analysis.Analyzer{err113.NewAnalyzer()},
16+
[]*analysis.Analyzer{a},
1517
nil,
1618
).WithLoadMode(goanalysis.LoadModeTypesInfo)
1719
}

pkg/lint/lintersdb/builder_linter.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -250,10 +250,11 @@ func (b LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
250250
WithPresets(linter.PresetStyle, linter.PresetComment).
251251
WithURL("https://github.com/matoous/godox"),
252252

253-
linter.NewConfig(golinters.NewGoerr113()).
253+
linter.NewConfig(golinters.NewErr113()).
254254
WithSince("v1.26.0").
255255
WithPresets(linter.PresetStyle, linter.PresetError).
256256
WithLoadForGoAnalysis().
257+
WithAlternativeNames("goerr113").
257258
WithURL("https://github.com/Djarvur/go-err113"),
258259

259260
linter.NewConfig(golinters.NewGofmt(&cfg.LintersSettings.Gofmt)).

pkg/printers/testdata/golden-json.json

+1-1
Large diffs are not rendered by default.

pkg/printers/testdata/in-report-data.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"Name": "godox"
136136
},
137137
{
138-
"Name": "goerr113"
138+
"Name": "err113"
139139
},
140140
{
141141
"Name": "gofmt",

test/testdata/err113.go

+21
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
//golangcitest:args -Eerr113
2+
package testdata
3+
4+
import "os"
5+
6+
func SimpleEqual(e1, e2 error) bool {
7+
return e1 == e2 // want `do not compare errors directly "e1 == e2", use "errors.Is\(e1, e2\)" instead`
8+
}
9+
10+
func SimpleNotEqual(e1, e2 error) bool {
11+
return e1 != e2 // want `do not compare errors directly "e1 != e2", use "!errors.Is\(e1, e2\)" instead`
12+
}
13+
14+
func CheckGoerr13Import(e error) bool {
15+
f, err := os.Create("f.txt")
16+
if err != nil {
17+
return err == e // want `do not compare errors directly "err == e", use "errors.Is\(err, e\)" instead`
18+
}
19+
f.Close()
20+
return false
21+
}

test/testdata/goerr113.go

-21
This file was deleted.

0 commit comments

Comments
 (0)