Skip to content

Commit a8d43c7

Browse files
committed
chore: remove unparam deprecated option
1 parent f924710 commit a8d43c7

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

pkg/config/linters_settings.go

-3
Original file line numberDiff line numberDiff line change
@@ -152,9 +152,6 @@ var defaultLintersSettings = LintersSettings{
152152
SkipRegexp: `(export|internal)_test\.go`,
153153
AllowPackages: []string{"main"},
154154
},
155-
Unparam: UnparamSettings{
156-
Algo: "cha",
157-
},
158155
Unused: UnusedSettings{
159156
FieldWritesAreUses: true,
160157
PostStatementsAreReads: false,

pkg/golinters/unparam/unparam.go

+1-6
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88

99
"github.com/golangci/golangci-lint/pkg/config"
1010
"github.com/golangci/golangci-lint/pkg/goanalysis"
11-
"github.com/golangci/golangci-lint/pkg/lint/linter"
1211
)
1312

1413
const linterName = "unparam"
@@ -33,11 +32,7 @@ func New(settings *config.UnparamSettings) *goanalysis.Linter {
3332
"Reports unused function parameters",
3433
[]*analysis.Analyzer{analyzer},
3534
nil,
36-
).WithContextSetter(func(lintCtx *linter.Context) {
37-
if settings.Algo != "cha" { // TODO(ldez): is it deprecated? Remove?
38-
lintCtx.Log.Warnf("`linters.settings.unparam.algo` isn't supported by the newest `unparam`")
39-
}
40-
}).WithLoadMode(goanalysis.LoadModeTypesInfo)
35+
).WithLoadMode(goanalysis.LoadModeTypesInfo)
4136
}
4237

4338
func runUnparam(pass *analysis.Pass, settings *config.UnparamSettings) error {

0 commit comments

Comments
 (0)