Skip to content

Commit a775985

Browse files
build(deps): bump github.com/go-critic/go-critic from 0.6.5 to 0.6.6 (#3616)
Co-authored-by: Fernandez Ludovic <[email protected]>
1 parent ba76af4 commit a775985

File tree

3 files changed

+26
-37
lines changed

3 files changed

+26
-37
lines changed

go.mod

+8-8
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ require (
3030
github.com/fatih/color v1.14.1
3131
github.com/firefart/nonamedreturns v1.0.4
3232
github.com/fzipp/gocyclo v0.6.0
33-
github.com/go-critic/go-critic v0.6.5
33+
github.com/go-critic/go-critic v0.6.6
3434
github.com/go-xmlfmt/xmlfmt v1.1.2
3535
github.com/gofrs/flock v0.8.1
3636
github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
@@ -128,13 +128,13 @@ require (
128128
github.com/fatih/structtag v1.2.0 // indirect
129129
github.com/fsnotify/fsnotify v1.5.4 // indirect
130130
github.com/go-ole/go-ole v1.2.6 // indirect
131-
github.com/go-toolsmith/astcast v1.0.0 // indirect
131+
github.com/go-toolsmith/astcast v1.1.0 // indirect
132132
github.com/go-toolsmith/astcopy v1.0.3 // indirect
133-
github.com/go-toolsmith/astequal v1.0.3 // indirect
134-
github.com/go-toolsmith/astfmt v1.0.0 // indirect
135-
github.com/go-toolsmith/astp v1.0.0 // indirect
136-
github.com/go-toolsmith/strparse v1.0.0 // indirect
137-
github.com/go-toolsmith/typep v1.0.2 // indirect
133+
github.com/go-toolsmith/astequal v1.1.0 // indirect
134+
github.com/go-toolsmith/astfmt v1.1.0 // indirect
135+
github.com/go-toolsmith/astp v1.1.0 // indirect
136+
github.com/go-toolsmith/strparse v1.1.0 // indirect
137+
github.com/go-toolsmith/typep v1.1.0 // indirect
138138
github.com/gobwas/glob v0.2.3 // indirect
139139
github.com/golang/protobuf v1.5.2 // indirect
140140
github.com/google/go-cmp v0.5.9 // indirect
@@ -179,7 +179,7 @@ require (
179179
go.uber.org/multierr v1.6.0 // indirect
180180
go.uber.org/zap v1.17.0 // indirect
181181
golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e // indirect
182-
golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a // indirect
182+
golang.org/x/exp/typeparams v0.0.0-20230203172020-98cc5a0785f9 // indirect
183183
golang.org/x/mod v0.8.0 // indirect
184184
golang.org/x/sync v0.1.0 // indirect
185185
golang.org/x/sys v0.5.0 // indirect

go.sum

+16-27
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/golinters/gocritic.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ func runGocriticOnFile(linterCtx *gocriticlinter.Context, f *ast.File, checks []
173173
// All checkers are expected to use *lint.Context
174174
// as read-only structure, so no copying is required.
175175
for _, warn := range c.Check(f) {
176-
pos := linterCtx.FileSet.Position(warn.Node.Pos())
176+
pos := linterCtx.FileSet.Position(warn.Pos)
177177
issue := result.Issue{
178178
Pos: pos,
179179
Text: fmt.Sprintf("%s: %s", c.Info.Name, warn.Text),
@@ -184,7 +184,7 @@ func runGocriticOnFile(linterCtx *gocriticlinter.Context, f *ast.File, checks []
184184
issue.Replacement = &result.Replacement{
185185
Inline: &result.InlineFix{
186186
StartCol: pos.Column - 1,
187-
Length: int(warn.Node.End() - warn.Node.Pos()),
187+
Length: int(warn.Suggestion.To - warn.Suggestion.From),
188188
NewString: string(warn.Suggestion.Replacement),
189189
},
190190
}

0 commit comments

Comments
 (0)