review: rephrase

ldez · ldez · commit a6b9d8204df2 · 2024-05-31T21:49:10.000+02:00
diff --git a/pkg/golinters/lll/lll.go b/pkg/golinters/lll/lll.go
@@ -121,7 +121,7 @@ func getLLLIssuesForFile(filename string, maxLineLen int, tabSpaces string) ([]r
 					Filename: filename,
 					Line:     lineNumber,
 				},
-				Text:       fmt.Sprintf("line is %d characters, max %d", lineLen, maxLineLen),
+				Text:       fmt.Sprintf("The line is %d characters long, which exceeds the maximum of %d characters.", lineLen, maxLineLen),
 				FromLinter: linterName,
 			})
 		}
diff --git a/test/run_test.go b/test/run_test.go
@@ -218,7 +218,7 @@ func TestLineDirective(t *testing.T) {
 			},
 			configPath: "testdata/linedirective/lll.yml",
 			targetPath: "linedirective",
-			expected:   "line is 57 characters, max 50 (lll)",
+			expected:   "The line is 57 characters long, which exceeds the maximum of 50 characters. (lll)",
 		},
 		{
 			desc: "misspell",

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ func getLLLIssuesForFile(filename string, maxLineLen int, tabSpaces string) ([]r`
`121`	`121`	`Filename: filename,`
`122`	`122`	`Line: lineNumber,`
`123`	`123`	`},`
`124`		`- Text: fmt.Sprintf("line is %d characters, max %d", lineLen, maxLineLen),`
	`124`	`+ Text: fmt.Sprintf("The line is %d characters long, which exceeds the maximum of %d characters.", lineLen, maxLineLen),`
`125`	`125`	`FromLinter: linterName,`
`126`	`126`	`})`
`127`	`127`	`}`
Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ func TestLineDirective(t *testing.T) {`
`218`	`218`	`},`
`219`	`219`	`configPath: "testdata/linedirective/lll.yml",`
`220`	`220`	`targetPath: "linedirective",`
`221`		`- expected: "line is 57 characters, max 50 (lll)",`
	`221`	`+ expected: "The line is 57 characters long, which exceeds the maximum of 50 characters. (lll)",`
`222`	`222`	`},`
`223`	`223`	`{`
`224`	`224`	`desc: "misspell",`