Remove "empty" and rename "duplicate" to "identical"

Author: uudashr

.golangci.next.reference.yml

@@ -1227,9 +1227,14 @@ linters-settings:
     # Default: []
     enable:
       - unused
-      - empty
-      - duplicate
+      - identical
       - opaque
+    settings:
+      unused:
+        # Comma-separated list of packages to exclude from the check.
+        # Default: []
+        exclude:
+          - github.com/example/log
 
   importas:
     # Do not allow unaliased imports of aliased packages.

go.sum

@@ -295,9 +295,8 @@
     },
     "iface-analyzers": {
       "enum": [
-        "empty",
         "unused",
-        "duplicate",
+        "identical",
         "opaque"
       ]
     },

jsonschema/golangci.next.jsonschema.json

@@ -5,17 +5,15 @@ import (
 
 	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/goanalysis"
-	"github.com/uudashr/iface/duplicate"
-	"github.com/uudashr/iface/empty"
+	"github.com/uudashr/iface/identical"
 	"github.com/uudashr/iface/opaque"
 	"github.com/uudashr/iface/unused"
 	"golang.org/x/tools/go/analysis"
 )
 
 var allAnalyzers = []*analysis.Analyzer{
 	unused.Analyzer,
-	empty.Analyzer,
-	duplicate.Analyzer,
+	identical.Analyzer,
 	opaque.Analyzer,
 }
 

pkg/golinters/iface/iface.go

@@ -13,11 +13,11 @@ func TestAnalyzersFromSettings(t *testing.T) {
 	}{
 		"nil analyzers": {
 			enable:          nil,
-			expectedEnabled: []string{"unused", "empty", "duplicate", "opaque"},
+			expectedEnabled: []string{"unused", "identical", "opaque"},
 		},
 		"empty analyzers": {
 			enable:          []string{},
-			expectedEnabled: []string{"unused", "empty", "duplicate", "opaque"},
+			expectedEnabled: []string{"unused", "identical", "opaque"},
 		},
 		"unused only": {
 			enable:          []string{"unused"},
@@ -32,8 +32,8 @@ func TestAnalyzersFromSettings(t *testing.T) {
 			expectedEnabled: []string{"unused", "opaque"},
 		},
 		"all analyzers": {
-			enable:          []string{"unused", "opaque", "empty", "duplicate"},
-			expectedEnabled: []string{"unused", "empty", "duplicate", "opaque"},
+			enable:          []string{"unused", "opaque", "identical"},
+			expectedEnabled: []string{"unused", "identical", "opaque"},
 		},
 	}
 

pkg/golinters/iface/iface_test.go

@@ -0,0 +1,11 @@
+//golangcitest:args -Eiface
+//golangcitest:config_path testdata/identical.yml
+package testdata
+
+type Pinger interface { // want "interface Pinger contains identical methods or type constraints from another interface, causing redundancy"
+	Ping() error
+}
+
+type Healthcheck interface { // want "interface Healthcheck contains identical methods or type constraints from another interface, causing redundancy"
+	Ping() error
+}

pkg/golinters/iface/testdata/duplicate.go

@@ -1,4 +1,4 @@
 linters-settings:
   iface:
     enable:
-      - duplicate
+      - identical