Skip to content

Commit 8a9d16e

Browse files
authored
Revert "Add filen linter (#5081)" (#5087)
1 parent be469a4 commit 8a9d16e

15 files changed

+0
-2237
lines changed

.golangci.next.reference.yml

-13
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ linters:
3636
- exhaustruct
3737
- exportloopref
3838
- fatcontext
39-
- filen
4039
- forbidigo
4140
- forcetypeassert
4241
- funlen
@@ -153,7 +152,6 @@ linters:
153152
- exhaustruct
154153
- exportloopref
155154
- fatcontext
156-
- filen
157155
- forbidigo
158156
- forcetypeassert
159157
- funlen
@@ -536,17 +534,6 @@ linters-settings:
536534
exclude:
537535
- '.+/cobra\.Command$'
538536

539-
filen:
540-
# Ignore comments when counting lines.
541-
# Default false
542-
ignore-comments: true
543-
# Max number of lines in a file.
544-
# Default: 1000
545-
max-lines: 500
546-
# Min number of lines in a file.
547-
# Default: 5
548-
min-lines: 1
549-
550537
forbidigo:
551538
# Forbid the following identifiers (list of regexp).
552539
# Default: ["^(fmt\\.Print(|f|ln)|print|println)$"]

go.mod

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ require (
1212
github.com/Antonboom/testifylint v1.5.0
1313
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c
1414
github.com/Crocmagnon/fatcontext v0.5.2
15-
github.com/DanilXO/filen v0.3.0
1615
github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
1716
github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.0
1817
github.com/OpenPeeDeeP/depguard/v2 v2.2.0

go.sum

-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

jsonschema/golangci.next.jsonschema.json

-21
Original file line numberDiff line numberDiff line change
@@ -1012,27 +1012,6 @@
10121012
}
10131013
}
10141014
},
1015-
"filen": {
1016-
"type": "object",
1017-
"additionalProperties": false,
1018-
"properties": {
1019-
"ignore-comments": {
1020-
"description": "Ignore comments when counting lines.",
1021-
"type": "boolean",
1022-
"default": false
1023-
},
1024-
"max-lines": {
1025-
"description": "Max number of lines in a file.",
1026-
"type": "integer",
1027-
"default": 1000
1028-
},
1029-
"min-lines": {
1030-
"description": "Min number of lines in a file.",
1031-
"type": "integer",
1032-
"default": 5
1033-
}
1034-
}
1035-
},
10361015
"forbidigo": {
10371016
"type": "object",
10381017
"additionalProperties": false,

pkg/config/linters_settings.go

-12
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ var defaultLintersSettings = LintersSettings{
4040
ExplicitExhaustiveMap: false,
4141
ExplicitExhaustiveSwitch: false,
4242
},
43-
Filen: FilenSettings{
44-
MinLines: 5,
45-
MaxLines: 1000,
46-
IgnoreComments: false,
47-
},
4843
Forbidigo: ForbidigoSettings{
4944
ExcludeGodocExamples: true,
5045
},
@@ -219,7 +214,6 @@ type LintersSettings struct {
219214
ErrorLint ErrorLintSettings
220215
Exhaustive ExhaustiveSettings
221216
Exhaustruct ExhaustructSettings
222-
Filen FilenSettings
223217
Forbidigo ForbidigoSettings
224218
Funlen FunlenSettings
225219
Gci GciSettings
@@ -424,12 +418,6 @@ type ExhaustructSettings struct {
424418
Exclude []string `mapstructure:"exclude"`
425419
}
426420

427-
type FilenSettings struct {
428-
IgnoreComments bool `mapstructure:"ignore-comments"`
429-
MaxLines int `mapstructure:"max-lines"`
430-
MinLines int `mapstructure:"min-lines"`
431-
}
432-
433421
type ForbidigoSettings struct {
434422
Forbid []ForbidigoPattern `mapstructure:"forbid"`
435423
ExcludeGodocExamples bool `mapstructure:"exclude-godoc-examples"`

pkg/golinters/filen/filen.go

-24
This file was deleted.

pkg/golinters/filen/filen_integration_test.go

-11
This file was deleted.

0 commit comments

Comments
 (0)