Add nosprintfhostport linter (#2749)

Author: stbenjam

.golangci.example.yml

@@ -1679,6 +1679,7 @@ linters:
     - nlreturn
     - noctx
     - nolintlint
+    - nosprintfhostport
     - paralleltest
     - prealloc
     - predeclared
@@ -1769,6 +1770,7 @@ linters:
     - nlreturn
     - noctx
     - nolintlint
+    - nosprintfhostport
     - paralleltest
     - prealloc
     - predeclared

go.mod

@@ -83,6 +83,7 @@ require (
 	github.com/spf13/pflag v1.0.5
 	github.com/spf13/viper v1.11.0
 	github.com/ssgreg/nlreturn/v2 v2.2.1
+	github.com/stbenjam/no-sprintf-host-port v0.1.0
 	github.com/stretchr/testify v1.7.1
 	github.com/sylvia7788/contextcheck v1.0.4
 	github.com/tdakkota/asciicheck v0.1.1

go.sum

@@ -0,0 +1,19 @@
+package golinters
+
+import (
+	"github.com/stbenjam/no-sprintf-host-port/pkg/analyzer"
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewNoSprintfHostPort() *goanalysis.Linter {
+	a := analyzer.Analyzer
+
+	return goanalysis.NewLinter(
+		a.Name,
+		a.Doc,
+		[]*analysis.Analyzer{a},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/nosprintfhostport.go

@@ -531,6 +531,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/firefart/nonamedreturns"),
 
+		linter.NewConfig(golinters.NewNoSprintfHostPort()).
+			WithSince("v1.46.0").
+			WithPresets(linter.PresetStyle).
+			WithURL("https://github.com/stbenjam/no-sprintf-host-port"),
+
 		linter.NewConfig(golinters.NewParallelTest()).
 			WithSince("v1.33.0").
 			WithPresets(linter.PresetStyle, linter.PresetTest).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,47 @@
+//args: -Enosprintfhostport
+package testdata
+
+import (
+	"fmt"
+	"net"
+)
+
+func _() {
+
+	_ = fmt.Sprintf("postgres://%s:%[email protected]/%s", "foo", "bar", "baz")
+
+	_ = fmt.Sprintf("http://api.%s/foo", "example.com")
+
+	_ = fmt.Sprintf("http://api.%s:6443/foo", "example.com")
+
+	_ = fmt.Sprintf("http://%s/foo", net.JoinHostPort("foo", "80"))
+
+	_ = fmt.Sprintf("9invalidscheme://%s:%d", "myHost", 70)
+
+	_ = fmt.Sprintf("gopher://%s/foo", net.JoinHostPort("foo", "80"))
+
+	_ = fmt.Sprintf("telnet+ssl://%s/foo", net.JoinHostPort("foo", "80"))
+
+	_ = fmt.Sprintf("http://%s/foo:bar", net.JoinHostPort("foo", "80"))
+
+	_ = fmt.Sprintf("http://user:password@%s/foo:bar", net.JoinHostPort("foo", "80"))
+
+	_ = fmt.Sprintf("http://example.com:9211")
+
+	_ = fmt.Sprintf("gopher://%s:%d", "myHost", 70) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	_ = fmt.Sprintf("telnet+ssl://%s:%d", "myHost", 23) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	_ = fmt.Sprintf("weird3.6://%s:%d", "myHost", 23) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	_ = fmt.Sprintf("https://user@%s:%d", "myHost", 8443) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	_ = fmt.Sprintf("postgres://%s:%s@%s:5050/%s", "foo", "bar", "baz", "qux") // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	_ = fmt.Sprintf("https://%s:%d", "myHost", 8443) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	_ = fmt.Sprintf("https://%s:9211", "myHost") // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
+	ip := "fd00::1"
+	_ = fmt.Sprintf("http://%s:1936/healthz", ip) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+}