refactor: apply the Fixer before user limitations and output transformations

Author: ldez

pkg/lint/runner.go

@@ -79,10 +79,12 @@ func NewRunner(log logutils.Log, cfg *config.Config, args []string, goenv *gouti
 			// Must be after FilenameUnadjuster.
 			processors.NewInvalidIssue(log.Child(logutils.DebugKeyInvalidIssue)),
 
-			// Must be before diff, nolint and exclude autogenerated processor at least.
+			// Must be before Diff, SkipFiles, SkipDirs,  ExcludeRules processors at least.
 			processors.NewPathPrettifier(log),
+
+			// must be after path prettifier
 			skipFilesProcessor,
-			skipDirsProcessor, // must be after path prettifier
+			skipDirsProcessor,
 
 			processors.NewAutogeneratedExclude(cfg.Issues.ExcludeGenerated),
 
@@ -94,20 +96,21 @@ func NewRunner(log logutils.Log, cfg *config.Config, args []string, goenv *gouti
 
 			processors.NewNolint(log.Child(logutils.DebugKeyNolint), dbManager, enabledLinters),
 
-			processors.NewUniqByLine(cfg),
 			processors.NewDiff(&cfg.Issues),
+
+			// The fixer still needs to see paths for the issues that are relative to the current directory.
+			processors.NewFixer(cfg, log, fileCache, metaFormatter),
+
+			// Must be after the Fixer.
+			processors.NewUniqByLine(cfg),
 			processors.NewMaxPerFileFromLinter(cfg),
 			processors.NewMaxSameIssues(cfg.Issues.MaxSameIssues, log.Child(logutils.DebugKeyMaxSameIssues), cfg),
 			processors.NewMaxFromLinter(cfg.Issues.MaxIssuesPerLinter, log.Child(logutils.DebugKeyMaxFromLinter), cfg),
 
+			// Now we can modify the issues for output.
 			processors.NewSourceCode(lineCache, log.Child(logutils.DebugKeySourceCode)),
 			processors.NewPathShortener(),
 			processors.NewSeverity(log.Child(logutils.DebugKeySeverityRules), files, &cfg.Severity),
-
-			// The fixer still needs to see paths for the issues that are relative to the current directory.
-			processors.NewFixer(cfg, log, fileCache, metaFormatter),
-
-			// Now we can modify the issues for output.
 			processors.NewPathPrefixer(cfg.Output.PathPrefix),
 			processors.NewSortResults(cfg),
 		},

pkg/result/processors/max_from_linter.go

@@ -35,11 +35,6 @@ func (p *MaxFromLinter) Process(issues []result.Issue) ([]result.Issue, error) {
 	}
 
 	return filterIssuesUnsafe(issues, func(issue *result.Issue) bool {
-		if issue.SuggestedFixes != nil && p.cfg.Issues.NeedFix {
-			// we need to fix all issues at once => we need to return all of them
-			return true
-		}
-
 		p.linterCounter[issue.FromLinter]++ // always inc for stat
 
 		return p.linterCounter[issue.FromLinter] <= p.limit

pkg/result/processors/max_same_issues.go

@@ -37,12 +37,8 @@ func (p *MaxSameIssues) Process(issues []result.Issue) ([]result.Issue, error) {
 	}
 
 	return filterIssuesUnsafe(issues, func(issue *result.Issue) bool {
-		if issue.SuggestedFixes != nil && p.cfg.Issues.NeedFix {
-			// we need to fix all issues at once => we need to return all of them
-			return true
-		}
-
 		p.textCounter[issue.Text]++ // always inc for stat
+
 		return p.textCounter[issue.Text] <= p.limit
 	}), nil
 }

pkg/result/processors/uniq_by_line.go

@@ -37,12 +37,6 @@ func (p *UniqByLine) Process(issues []result.Issue) ([]result.Issue, error) {
 func (*UniqByLine) Finish() {}
 
 func (p *UniqByLine) shouldPassIssue(issue *result.Issue) bool {
-	if issue.SuggestedFixes != nil && p.cfg.Issues.NeedFix {
-		// if issue will be auto-fixed we shouldn't collapse issues:
-		// e.g. one line can contain 2 misspellings, they will be in 2 issues and misspell should fix both of them.
-		return true
-	}
-
 	if p.fileLineCounter.GetCount(issue) == uniqByLineLimit {
 		return false
 	}