gci: fix panic with invalid configuration option (#3019)

ldez · web-flow · commit 886fbd71a864 · 2022-07-27T09:14:33.000+02:00
diff --git a/pkg/golinters/gci.go b/pkg/golinters/gci.go
@@ -46,7 +46,11 @@ func NewGci(settings *config.GciSettings) *goanalysis.Linter {
 			rawCfg.SectionStrings = prefix
 		}
 
-		cfg, _ = rawCfg.Parse()
+		var err error
+		cfg, err = rawCfg.Parse()
+		if err != nil {
+			linterLogger.Fatalf("gci: configuration parsing: %v", err)
+		}
 	}
 
 	var lock sync.Mutex

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,11 @@ func NewGci(settings config.GciSettings) goanalysis.Linter {`
`46`	`46`	`rawCfg.SectionStrings = prefix`
`47`	`47`	`}`
`48`	`48`
`49`		`- cfg, _ = rawCfg.Parse()`
	`49`	`+ var err error`
	`50`	`+ cfg, err = rawCfg.Parse()`
	`51`	`+ if err != nil {`
	`52`	`+ linterLogger.Fatalf("gci: configuration parsing: %v", err)`
	`53`	`+ }`
`50`	`54`	`}`
`51`	`55`
`52`	`56`	`var lock sync.Mutex`