Rename gosprintfhostport to nosprintfhostport

Author: stbenjam

.golangci.example.yml

@@ -1660,7 +1660,6 @@ linters:
     - goprintffuncname
     - gosec
     - gosimple
-    - gosprintfhostport
     - govet
     - ifshort
     - importas
@@ -1678,6 +1677,7 @@ linters:
     - nlreturn
     - noctx
     - nolintlint
+    - nosprintfhostport
     - paralleltest
     - prealloc
     - predeclared
@@ -1751,7 +1751,6 @@ linters:
     - goprintffuncname
     - gosec
     - gosimple
-    - gosprintfhostport
     - govet
     - ifshort
     - importas
@@ -1769,6 +1768,7 @@ linters:
     - nlreturn
     - noctx
     - nolintlint
+    - nosprintfhostport
     - paralleltest
     - prealloc
     - predeclared

go.mod

@@ -153,7 +153,6 @@ require (
 	github.com/spf13/afero v1.6.0 // indirect
 	github.com/spf13/cast v1.4.1 // indirect
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
-	github.com/stbenjam/go-sprintf-host-port v0.0.1
 	github.com/stretchr/objx v0.1.1 // indirect
 	github.com/subosito/gotenv v1.2.0 // indirect
 	github.com/tklauser/go-sysconf v0.3.10 // indirect
@@ -171,3 +170,5 @@ require (
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b // indirect
 )
+
+require github.com/stbenjam/no-sprintf-host-port v0.1.0

go.sum

@@ -1,13 +1,13 @@
 package golinters
 
 import (
-	"github.com/stbenjam/go-sprintf-host-port/pkg/analyzer"
+	"github.com/stbenjam/no-sprintf-host-port/pkg/analyzer"
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 )
 
-func NewGoSprintfHostPort() *goanalysis.Linter {
+func NewNoSprintfHostPort() *goanalysis.Linter {
 	a := analyzer.Analyzer
 
 	return goanalysis.NewLinter(

pkg/golinters/gosprintfhostport.go renamed to pkg/golinters/nosprintfhostport.go

@@ -421,11 +421,6 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithAlternativeNames(megacheckName).
 			WithURL("https://github.com/dominikh/go-tools/tree/master/simple"),
 
-		linter.NewConfig(golinters.NewGoSprintfHostPort()).
-			WithSince("v1.46.0").
-			WithPresets(linter.PresetStyle).
-			WithURL("https://github.com/stbenjam/go-sprintf-host-port"),
-
 		linter.NewConfig(golinters.NewGovet(govetCfg)).
 			WithSince("v1.0.0").
 			WithLoadForGoAnalysis().
@@ -531,6 +526,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithURL("https://github.com/sonatard/noctx").
 			WithNoopFallback(m.cfg),
 
+		linter.NewConfig(golinters.NewNoSprintfHostPort()).
+			WithSince("v1.46.0").
+			WithPresets(linter.PresetStyle).
+			WithURL("https://github.com/stbenjam/no-sprintf-host-port"),
+
 		linter.NewConfig(golinters.NewParallelTest()).
 			WithSince("v1.33.0").
 			WithPresets(linter.PresetStyle, linter.PresetTest).

pkg/lint/lintersdb/manager.go

@@ -1,4 +1,4 @@
-//args: -Egosprintfhostport
+//args: -Enosprintfhostport
 package testdata
 
 import (
@@ -7,15 +7,18 @@ import (
 )
 
 func _() {
-	_ = fmt.Sprintf("gopher://%s/foo", net.JoinHostPort("foo", "80"))
 
 	_ = fmt.Sprintf("postgres://%s:%[email protected]/%s", "foo", "bar", "baz")
 
-	_ = fmt.Sprintf("http://%s/foo", net.JoinHostPort("foo", "80"))
+	_ = fmt.Sprintf("http://api.%s/foo", "example.com")
 
 	_ = fmt.Sprintf("http://api.%s:6443/foo", "example.com")
 
-	_ = fmt.Sprintf("http://api.%s/foo", "example.com")
+	_ = fmt.Sprintf("http://%s/foo", net.JoinHostPort("foo", "80"))
+
+	_ = fmt.Sprintf("9invalidscheme://%s:%d", "myHost", 70)
+
+	_ = fmt.Sprintf("gopher://%s/foo", net.JoinHostPort("foo", "80"))
 
 	_ = fmt.Sprintf("telnet+ssl://%s/foo", net.JoinHostPort("foo", "80"))
 
@@ -29,6 +32,8 @@ func _() {
 
 	_ = fmt.Sprintf("telnet+ssl://%s:%d", "myHost", 23) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
 
+	_ = fmt.Sprintf("weird3.6://%s:%d", "myHost", 23) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
+
 	_ = fmt.Sprintf("https://user@%s:%d", "myHost", 8443) // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"
 
 	_ = fmt.Sprintf("postgres://%s:%s@%s:5050/%s", "foo", "bar", "baz", "qux") // ERROR "host:port in url should be constructed with net.JoinHostPort and not directly with fmt.Sprintf"