tests: update linter tests

Author: ldez

pkg/golinters/errcheck/testdata/errcheck.go

@@ -21,7 +21,7 @@ func IgnoreCloseMissingErrHandling() error {
 		return err
 	}
 
-	f.Close()
+	f.Close() // want "Error return value of `f.Close` is not checked"
 	return nil
 }
 
@@ -30,14 +30,14 @@ func IgnoreCloseInDeferMissingErrHandling() {
 	if err != nil {
 		panic(err)
 	}
-	defer resp.Body.Close()
+	defer resp.Body.Close() // want "Error return value of `resp.Body.Close` is not checked"
 
 	panic(resp)
 }
 
 func IgnoreStdxWrite() {
-	os.Stdout.Write([]byte{})
-	os.Stderr.Write([]byte{})
+	os.Stdout.Write([]byte{}) // want "Error return value of `os.Stdout.Write` is not checked"
+	os.Stderr.Write([]byte{}) // want "Error return value of `os.Stderr.Write` is not checked"
 }
 
 func IgnoreBufferWrites(buf *bytes.Buffer) {

pkg/golinters/exhaustive/testdata/exhaustive_generated.go

@@ -34,5 +34,5 @@ func GosecG204SubprocWithFunc() {
 		return "/tmp/dummy"
 	}
 
-	exec.Command("ls", arg()).Run() // want "G204: Subprocess launched with a potential tainted input or cmd arguments"
+	exec.Command("ls", arg()).Run() // want "G104: Errors unhandled"
 }

pkg/golinters/gosec/testdata/gosec.go

@@ -7,7 +7,7 @@ import (
 	"time"
 )
 
-func SampleRevive(t *time.Duration) error {
+func SampleRevive(t *time.Duration) error { // want "exported: exported function SampleRevive should have comment or be unexported"
 	if t == nil {
 		return nil
 	} else {

pkg/golinters/revive/testdata/revive.go

@@ -6,7 +6,6 @@ linters-settings:
     severity: warning
     rules:
       - name: exported
-      - name: package-comments
       - name: cognitive-complexity
         arguments: [ 7 ]
       - name: line-length-limit

pkg/golinters/revive/testdata/revive.yml

@@ -1,4 +1,5 @@
 //golangcitest:args -Erevive
+// Package testdata ...
 package testdata
 
 import (

pkg/golinters/revive/testdata/revive_default.go

@@ -1,3 +1,5 @@
+// Package testdata ...
+//
 //golangcitest:args -Estylecheck
 //golangcitest:expected_exitcode 0
 package testdata

pkg/golinters/stylecheck/testdata/fix/in/stylecheck.go

@@ -1,3 +1,5 @@
+// Package testdata ...
+//
 //golangcitest:args -Estylecheck
 //golangcitest:expected_exitcode 0
 package testdata

pkg/golinters/stylecheck/testdata/fix/out/stylecheck.go

@@ -1,4 +1,5 @@
 //golangcitest:args -Estylecheck
+// Package testdata ...
 package testdata
 
 func Stylecheck(x int) {

pkg/golinters/stylecheck/testdata/stylecheck.go

@@ -1,4 +1,5 @@
 //golangcitest:args -Estylecheck
+// Package testdata ...
 package testdata
 
 /*

pkg/golinters/stylecheck/testdata/stylecheck_cgo.go

@@ -1,5 +1,6 @@
 //golangcitest:args -Emegacheck
 //golangcitest:expected_exitcode 0
+// Package testdata ...
 package testdata
 
 func StylecheckNotInMegacheck(x int) {