feat: change Builder interface to return error

Author: ldez

.golangci.yml

@@ -33,6 +33,9 @@ linters-settings:
       - whyNoLint
   gocyclo:
     min-complexity: 15
+  godox:
+    keywords:
+      - FIXME
   gofmt:
     rewrite-rules:
       - pattern: 'interface{}'
@@ -96,6 +99,7 @@ linters:
     - goconst
     - gocritic
     - gocyclo
+    - godox
     - gofmt
     - goimports
     - gomnd
@@ -123,7 +127,6 @@ linters:
   # - gochecknoglobals
   # - gocognit
   # - godot
-  # - godox
   # - goerr113
   # - nestif
   # - prealloc

pkg/commands/internal/builder.go

@@ -88,7 +88,7 @@ func (b Builder) clone(ctx context.Context) error {
 	cmd := exec.CommandContext(ctx,
 		"git", "clone", "--branch", b.cfg.Version,
 		"--single-branch", "--depth", "1", "-c advice.detachedHead=false", "-q",
-		"https://github.com/ldez/golangci-lint.git", // FIXME(ldez) use https://github.com/golangci/golangci-lint.git
+		"https://github.com/golangci/golangci-lint.git",
 	)
 	cmd.Dir = b.root
 

pkg/lint/lintersdb/builder_linter.go

@@ -16,9 +16,9 @@ func NewLinterBuilder() *LinterBuilder {
 
 // Build loads all the "internal" linters.
 // The configuration is use for the linter settings.
-func (b LinterBuilder) Build(cfg *config.Config) []*linter.Config {
+func (b LinterBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 	if cfg == nil {
-		return nil
+		return nil, nil
 	}
 
 	const megacheckName = "megacheck"
@@ -707,5 +707,5 @@ func (b LinterBuilder) Build(cfg *config.Config) []*linter.Config {
 			WithSince("v1.26.0").
 			WithPresets(linter.PresetStyle).
 			WithURL("https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/nolintlint/README.md"),
-	}
+	}, nil
 }

pkg/lint/lintersdb/builder_plugin_go.go

@@ -29,9 +29,9 @@ func NewPluginGoBuilder(log logutils.Log) *PluginGoBuilder {
 }
 
 // Build loads custom linters that are specified in the golangci-lint config file.
-func (b *PluginGoBuilder) Build(cfg *config.Config) []*linter.Config {
+func (b *PluginGoBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 	if cfg == nil || b.log == nil {
-		return nil
+		return nil, nil
 	}
 
 	var linters []*linter.Config
@@ -40,13 +40,13 @@ func (b *PluginGoBuilder) Build(cfg *config.Config) []*linter.Config {
 		settings := settings
 		lc, err := b.loadConfig(cfg, name, &settings)
 		if err != nil {
-			b.log.Errorf("Unable to load custom analyzer %s:%s, %v", name, settings.Path, err)
+			return nil, fmt.Errorf("unable to load custom analyzer %s:%s, %w", name, settings.Path, err)
 		} else {
 			linters = append(linters, lc)
 		}
 	}
 
-	return linters
+	return linters, nil
 }
 
 // loadConfig loads the configuration of private linters.

pkg/lint/lintersdb/builder_plugin_module.go

@@ -1,6 +1,7 @@
 package lintersdb
 
 import (
+	"fmt"
 	"strings"
 
 	"github.com/golangci/plugin-module-register/register"
@@ -24,9 +25,9 @@ func NewPluginModuleBuilder(log logutils.Log) *PluginModuleBuilder {
 }
 
 // Build loads custom linters that are specified in the golangci-lint config file.
-func (b *PluginModuleBuilder) Build(cfg *config.Config) []*linter.Config {
+func (b *PluginModuleBuilder) Build(cfg *config.Config) ([]*linter.Config, error) {
 	if cfg == nil || b.log == nil {
-		return nil
+		return nil, nil
 	}
 
 	var linters []*linter.Config
@@ -40,23 +41,17 @@ func (b *PluginModuleBuilder) Build(cfg *config.Config) []*linter.Config {
 
 		newPlugin, err := register.GetPlugin(name)
 		if err != nil {
-			// FIXME error
-			b.log.Fatalf("plugin(%s): %v", name, err)
-			return nil
+			return nil, fmt.Errorf("plugin(%s): %w", name, err)
 		}
 
 		p, err := newPlugin(settings.Settings)
 		if err != nil {
-			// FIXME error
-			b.log.Fatalf("plugin(%s): newPlugin %v", name, err)
-			return nil
+			return nil, fmt.Errorf("plugin(%s): newPlugin %w", name, err)
 		}
 
 		analyzers, err := p.BuildAnalyzers()
 		if err != nil {
-			// FIXME error
-			b.log.Fatalf("plugin(%s): BuildAnalyzers %v", name, err)
-			return nil
+			return nil, fmt.Errorf("plugin(%s): BuildAnalyzers %w", name, err)
 		}
 
 		customLinter := goanalysis.NewLinter(name, settings.Description, analyzers, nil)
@@ -86,5 +81,5 @@ func (b *PluginModuleBuilder) Build(cfg *config.Config) []*linter.Config {
 		linters = append(linters, lc)
 	}
 
-	return linters
+	return linters, nil
 }

pkg/lint/lintersdb/manager.go

@@ -1,6 +1,7 @@
 package lintersdb
 
 import (
+	"fmt"
 	"os"
 	"slices"
 	"sort"
@@ -17,7 +18,7 @@ import (
 const EnvTestRun = "GL_TEST_RUN"
 
 type Builder interface {
-	Build(cfg *config.Config) []*linter.Config
+	Build(cfg *config.Config) ([]*linter.Config, error)
 }
 
 // Manager is a type of database for all linters (internals or plugins).
@@ -48,7 +49,12 @@ func NewManager(log logutils.Log, cfg *config.Config, builders ...Builder) (*Man
 	}
 
 	for _, builder := range builders {
-		m.linters = append(m.linters, builder.Build(m.cfg)...)
+		linters, err := builder.Build(m.cfg)
+		if err != nil {
+			return nil, fmt.Errorf("build linters: %w", err)
+		}
+
+		m.linters = append(m.linters, linters...)
 	}
 
 	for _, lc := range m.linters {