review

ldez · sivchari · commit 635248a96298 · 2022-06-29T00:37:09.000+09:00
diff --git a/go.mod b/go.mod
@@ -155,7 +155,7 @@ require (
 	github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5 // indirect
 	github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95 // indirect
 	github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
-	github.com/sivchari/nosnakecase v1.3.0
+	github.com/sivchari/nosnakecase v1.5.0
 	github.com/spf13/afero v1.8.2 // indirect
 	github.com/spf13/cast v1.5.0 // indirect
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
diff --git a/go.sum b/go.sum
diff --git a/test/run_test.go b/test/run_test.go
@@ -95,7 +95,7 @@ func TestTestsAreLintedByDefault(t *testing.T) {
 }
 
 func TestCgoOk(t *testing.T) {
-	testshared.NewLintRunner(t).Run("--no-config", "--enable-all", getTestDataDir("cgo")).ExpectNoIssues()
+	testshared.NewLintRunner(t).Run("--no-config", "--enable-all", "-D", "nosnakecase", getTestDataDir("cgo")).ExpectNoIssues()
 }
 
 func TestCgoWithIssues(t *testing.T) {
diff --git a/test/testdata/cgo/main.go b/test/testdata/cgo/main.go
@@ -14,7 +14,6 @@ import (
 	"unsafe"
 )
 
-//nolint:nosnakecase
 func Example() {
 	cs := C.CString("Hello from stdio\n")
 	C.myprint(cs)
diff --git a/test/testdata/noctx.go b/test/testdata/noctx.go
@@ -1,5 +1,5 @@
 //args: -Enoctx
-package testdata
+package testdata_test
 
 import (
 	"context"
@@ -131,4 +131,3 @@ func Noctx() {
 		return req14, req15
 	}()
 }
-

-Original file line number
+Diff line change
 	github.com/quasilyte/gogrep v0.0.0-20220120141003-628d8b3623b5 // indirect
 	github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95 // indirect
 	github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
 -	github.com/sivchari/nosnakecase v1.3.0
 +	github.com/sivchari/nosnakecase v1.5.0
 	github.com/spf13/afero v1.8.2 // indirect
 	github.com/spf13/cast v1.5.0 // indirect
 	github.com/spf13/jwalterweatherman v1.1.0 // indirect
Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ func TestTestsAreLintedByDefault(t *testing.T) {`
`95`	`95`	`}`
`96`	`96`
`97`	`97`	`func TestCgoOk(t *testing.T) {`
`98`		`- testshared.NewLintRunner(t).Run("--no-config", "--enable-all", getTestDataDir("cgo")).ExpectNoIssues()`
	`98`	`+ testshared.NewLintRunner(t).Run("--no-config", "--enable-all", "-D", "nosnakecase", getTestDataDir("cgo")).ExpectNoIssues()`
`99`	`99`	`}`
`100`	`100`
`101`	`101`	`func TestCgoWithIssues(t *testing.T) {`
Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,6 @@ import (`
`14`	`14`	`"unsafe"`
`15`	`15`	`)`
`16`	`16`
`17`		`-//nolint:nosnakecase`
`18`	`17`	`func Example() {`
`19`	`18`	`cs := C.CString("Hello from stdio\n")`
`20`	`19`	`C.myprint(cs)`