Add errchkjson linter

Author: breml

.golangci.example.yml

@@ -91,6 +91,11 @@ linters-settings:
     # should ignore tests (default false)
     skip-tests: false
 
+  errchkjson:
+    # with omit-safe set to true, errchkjson does not warn about errors from json encoding functions that are safe
+    # to be ignored, because they are not possible to happen (default false)
+    omit-safe: false
+
   dogsled:
     # checks assignments with too many blank identifiers; default is 2
     max-blank-identifiers: 2

go.mod

@@ -16,6 +16,7 @@ require (
 	github.com/blizzy78/varnamelen v0.4.0
 	github.com/bombsimon/wsl/v3 v3.3.0
 	github.com/breml/bidichk v0.1.1
+	github.com/breml/errchkjson v0.1.0
 	github.com/butuzov/ireturn v0.1.1
 	github.com/charithe/durationcheck v0.0.9
 	github.com/daixiang0/gci v0.2.9

go.sum

@@ -88,6 +88,7 @@ type LintersSettings struct {
 	Dogsled          DogsledSettings
 	Dupl             DuplSettings
 	Errcheck         ErrcheckSettings
+	ErrChkJSON       ErrChkJSONSettings
 	ErrorLint        ErrorLintSettings
 	Exhaustive       ExhaustiveSettings
 	ExhaustiveStruct ExhaustiveStructSettings
@@ -152,6 +153,10 @@ type Cyclop struct {
 	SkipTests      bool    `mapstructure:"skip-tests"`
 }
 
+type ErrChkJSONSettings struct {
+	OmitSafe bool `mapstructure:"omit-safe"`
+}
+
 type DepGuardSettings struct {
 	ListType                 string `mapstructure:"list-type"`
 	Packages                 []string

pkg/config/linters_settings.go

@@ -0,0 +1,31 @@
+package golinters
+
+import (
+	"golang.org/x/tools/go/analysis"
+
+	"github.com/breml/errchkjson"
+
+	"github.com/golangci/golangci-lint/pkg/config"
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+)
+
+func NewErrChkJSONFuncName(cfg *config.ErrChkJSONSettings) *goanalysis.Linter {
+	a := errchkjson.NewAnalyzer()
+
+	cfgMap := map[string]map[string]interface{}{}
+	if cfg != nil {
+		if cfg.OmitSafe {
+			cfgMap[a.Name] = map[string]interface{}{
+				"omit-safe": "true",
+			}
+		}
+	}
+
+	return goanalysis.NewLinter(
+		"errchkjson",
+		"Checks types passed to the json encoding functions. "+
+			"Reports unsupported types and reports occations, where the check for the returned error can be omitted.",
+		[]*analysis.Analyzer{a},
+		cfgMap,
+	).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}

pkg/golinters/errchkjson.go

@@ -101,6 +101,7 @@ func enableLinterConfigs(lcs []*linter.Config, isEnabled func(lc *linter.Config)
 //nolint:funlen
 func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 	var cyclopCfg *config.Cyclop
+	var errchkjsonCfg *config.ErrChkJSONSettings
 	var errorlintCfg *config.ErrorLintSettings
 	var exhaustiveCfg *config.ExhaustiveSettings
 	var exhaustiveStructCfg *config.ExhaustiveStructSettings
@@ -127,6 +128,7 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 
 	if m.cfg != nil {
 		cyclopCfg = &m.cfg.LintersSettings.Cyclop
+		errchkjsonCfg = &m.cfg.LintersSettings.ErrChkJSON
 		errorlintCfg = &m.cfg.LintersSettings.ErrorLint
 		exhaustiveCfg = &m.cfg.LintersSettings.Exhaustive
 		exhaustiveStructCfg = &m.cfg.LintersSettings.ExhaustiveStruct
@@ -546,6 +548,11 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithSince("1.43.0").
 			WithPresets(linter.PresetBugs).
 			WithURL("https://github.com/breml/bidichk"),
+		linter.NewConfig(golinters.NewErrChkJSONFuncName(errchkjsonCfg)).
+			WithSince("1.44.0").
+			WithPresets(linter.PresetBugs, linter.PresetUnused).
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/breml/errchkjson"),
 
 		// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives
 		linter.NewConfig(golinters.NewNoLintLint()).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,2 @@
+issues:
+  max-issues-per-linter: 100

test/testdata/configs/errchkjson.yml

@@ -0,0 +1,5 @@
+issues:
+  max-issues-per-linter: 100
+linters-settings:
+  errchkjson:
+    omit-safe: true