chore: remove runOnPackage

ldez · ldez · commit 407af4c24e27 · 2025-04-01T08:32:47.000+02:00
diff --git a/pkg/golinters/gocritic/gocritic.go b/pkg/golinters/gocritic/gocritic.go
@@ -113,7 +113,9 @@ func (w *goCriticWrapper) run(pass *analysis.Pass) error {
 
 	linterCtx.SetPackageInfo(pass.TypesInfo, pass.Pkg)
 
-	runOnPackage(pass, enabledCheckers, pass.Files)
+	for _, f := range pass.Files {
+		runOnFile(pass, f, enabledCheckers)
+	}
 
 	return nil
 }
@@ -195,12 +197,6 @@ func (w *goCriticWrapper) normalizeCheckerParamsValue(p any) any {
 	}
 }
 
-func runOnPackage(pass *analysis.Pass, checks []*gocriticlinter.Checker, files []*ast.File) {
-	for _, f := range files {
-		runOnFile(pass, f, checks)
-	}
-}
-
 func runOnFile(pass *analysis.Pass, f *ast.File, checks []*gocriticlinter.Checker) {
 	for _, c := range checks {
 		// All checkers are expected to use *lint.Context

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,9 @@ func (w goCriticWrapper) run(pass analysis.Pass) error {`
`113`	`113`
`114`	`114`	`linterCtx.SetPackageInfo(pass.TypesInfo, pass.Pkg)`
`115`	`115`
`116`		`- runOnPackage(pass, enabledCheckers, pass.Files)`
	`116`	`+ for _, f := range pass.Files {`
	`117`	`+ runOnFile(pass, f, enabledCheckers)`
	`118`	`+ }`
`117`	`119`
`118`	`120`	`return nil`
`119`	`121`	`}`
`@@ -195,12 +197,6 @@ func (w *goCriticWrapper) normalizeCheckerParamsValue(p any) any {`
`195`	`197`	`}`
`196`	`198`	`}`
`197`	`199`
`198`		`-func runOnPackage(pass analysis.Pass, checks []gocriticlinter.Checker, files []*ast.File) {`
`199`		`- for _, f := range files {`
`200`		`- runOnFile(pass, f, checks)`
`201`		`- }`
`202`		`-}`
`203`		`-`
`204`	`200`	`func runOnFile(pass analysis.Pass, f ast.File, checks []*gocriticlinter.Checker) {`
`205`	`201`	`for _, c := range checks {`
`206`	`202`	`// All checkers are expected to use *lint.Context`