fix: improve staticcheck migration (#5545)

Author: ldez

pkg/commands/internal/migrate/migrate_linter_names.go

@@ -885,6 +885,27 @@ func convertStaticcheckLinterNames(names []string) []string {
 	return Unique(results)
 }
 
+func convertDisabledStaticcheckLinterNames(names []string) []string {
+	removeStaticcheck := slices.Contains(names, "staticcheck") && slices.Contains(names, "stylecheck") && slices.Contains(names, "gosimple")
+
+	var results []string
+
+	for _, name := range names {
+		if removeStaticcheck && slices.Contains([]string{"stylecheck", "gosimple", "staticcheck"}, name) {
+			results = append(results, "staticcheck")
+			continue
+		}
+
+		if slices.Contains([]string{"stylecheck", "gosimple"}, name) {
+			continue
+		}
+
+		results = append(results, name)
+	}
+
+	return Unique(results)
+}
+
 func onlyLinterNames(names []string) []string {
 	formatters := []string{"gci", "gofmt", "gofumpt", "goimports"}
 

pkg/commands/internal/migrate/migrate_linters.go

@@ -12,7 +12,7 @@ func toLinters(old *versionone.Config) versiontwo.Linters {
 	return versiontwo.Linters{
 		Default:    getDefaultName(old.Linters),
 		Enable:     onlyLinterNames(convertStaticcheckLinterNames(enable)),
-		Disable:    onlyLinterNames(convertStaticcheckLinterNames(disable)),
+		Disable:    onlyLinterNames(convertDisabledStaticcheckLinterNames(disable)),
 		FastOnly:   nil,
 		Settings:   toLinterSettings(old.LintersSettings),
 		Exclusions: toExclusions(old),

pkg/commands/internal/migrate/testdata/yaml/linters_09.golden.yml

@@ -43,7 +43,6 @@ linters:
     - mnd
     - mycustomlinter3
     - mycustomlinter4
-    - staticcheck
 formatters:
   enable:
     - gofmt

pkg/commands/internal/migrate/testdata/yaml/linters_13_a.golden.yml

@@ -0,0 +1 @@
+version: "2"

pkg/commands/internal/migrate/testdata/yaml/linters_13_a.yml

@@ -0,0 +1,13 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-use-default: false
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+linters:
+  enable:
+    - staticcheck
+  disable:
+    - stylecheck

pkg/commands/internal/migrate/testdata/yaml/linters_13_b.golden.yml

@@ -0,0 +1,9 @@
+version: "2"
+linters:
+  default: all
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - gofumpt
+    - goimports

pkg/commands/internal/migrate/testdata/yaml/linters_13_b.yml

@@ -0,0 +1,12 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-use-default: false
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+linters:
+  enable-all: true
+  disable:
+    - gosimple

pkg/commands/internal/migrate/testdata/yaml/linters_13_c.golden.yml

@@ -0,0 +1 @@
+version: "2"

pkg/commands/internal/migrate/testdata/yaml/linters_13_c.yml

@@ -0,0 +1,11 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-use-default: false
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+linters:
+  disable:
+    - stylecheck

pkg/commands/internal/migrate/testdata/yaml/linters_13_d.golden.yml

@@ -0,0 +1,4 @@
+version: "2"
+linters:
+  disable:
+    - staticcheck

pkg/commands/internal/migrate/testdata/yaml/linters_13_d.yml

@@ -0,0 +1,13 @@
+issues:
+  # Only to not generate unrelated elements inside golden.
+  exclude-use-default: false
+  # Only to not generate unrelated elements inside golden.
+  exclude-generated: strict
+  # Only to not generate unrelated elements inside golden.
+  exclude-dirs-use-default: false
+
+linters:
+  disable:
+    - staticcheck
+    - stylecheck
+    - gosimple