Skip to content

Commit 36d8d88

Browse files
committed
Preserve API backward compatibility
1 parent 15c7569 commit 36d8d88

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

pkg/config/config.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,11 @@ var DefaultExcludePatterns = []ExcludePattern{
101101
},
102102
}
103103

104-
func GetDefaultExcludePatternsStrings(include []string) []string {
104+
func GetDefaultExcludePatternsStrings() []string {
105+
return GetExcludePatternsStrings(nil)
106+
}
107+
108+
func GetExcludePatternsStrings(include []string) []string {
105109
includeMap := make(map[string]bool, len(include))
106110
for _, inc := range include {
107111
includeMap[inc] = true

pkg/lint/runner.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func NewRunner(cfg *config.Config, log logutils.Log, goenv *goutil.Env,
3232
icfg := cfg.Issues
3333
excludePatterns := icfg.ExcludePatterns
3434
if icfg.UseDefaultExcludes {
35-
excludePatterns = append(excludePatterns, config.GetDefaultExcludePatternsStrings(icfg.IncludeDefaultExcludes)...)
35+
excludePatterns = append(excludePatterns, config.GetExcludePatternsStrings(icfg.IncludeDefaultExcludes)...)
3636
}
3737

3838
var excludeTotalPattern string

test/bench/bench_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ func getGometalinterCommonArgs() []string {
7777
"--vendor",
7878
"--cyclo-over=30",
7979
"--dupl-threshold=150",
80-
"--exclude", fmt.Sprintf("(%s)", strings.Join(config.GetDefaultExcludePatternsStrings(nil), "|")),
80+
"--exclude", fmt.Sprintf("(%s)", strings.Join(config.GetDefaultExcludePatternsStrings(), "|")),
8181
"--disable-all",
8282
"--enable=vet",
8383
"--enable=vetshadow",

0 commit comments

Comments
 (0)