review

Author: ldez

pkg/commands/internal/migrate/migrate_linters_settings.go

@@ -346,12 +346,12 @@ func toGoCriticSettings(old versionone.GoCriticSettings) versiontwo.GoCriticSett
 		DisabledTags:   old.DisabledTags,
 	}
 
-	for k, checkSettings := range settings.SettingsPerCheck {
+	for k, checkSettings := range old.SettingsPerCheck {
 		if settings.SettingsPerCheck == nil {
 			settings.SettingsPerCheck = make(map[string]versiontwo.GoCriticCheckSettings)
 		}
 
-		settings.SettingsPerCheck[k] = checkSettings
+		settings.SettingsPerCheck[k] = versiontwo.GoCriticCheckSettings(checkSettings)
 	}
 
 	return settings

pkg/commands/internal/migrate/testdata/linters-settings_gocritic.golden.yml

@@ -230,3 +230,36 @@ linters:
         - performance
         - experimental
         - opinionated
+      settings:
+        captlocal:
+          paramsonly: false
+        commentedoutcode:
+          minlength: 50
+        elseif:
+          skipbalanced: false
+        hugeparam:
+          sizethreshold: 70
+        ifelsechain:
+          minthreshold: 4
+        nestingreduce:
+          bodywidth: 4
+        rangeexprcopy:
+          sizethreshold: 516
+          skiptestfuncs: false
+        rangevalcopy:
+          sizethreshold: 32
+          skiptestfuncs: false
+        ruleguard:
+          debug: emptyDecl
+          disable: myGroupName,#myTagName
+          enable: myGroupName,#myTagName
+          failon: dsl,import
+          rules: ${configDir}/ruleguard/rules-*.go,${configDir}/myrule1.go
+        toomanyresultschecker:
+          maxresults: 10
+        truncatecmp:
+          skiparchdependent: false
+        underef:
+          skiprecvderef: false
+        unnamedresult:
+          checkexported: true