fix: sanitize level property for SARIF (#4831)

Zxilly · ldez · web-flow · commit 304e22a024f3 · 2024-06-20T00:25:53.000+02:00
Co-authored-by: Fernandez Ludovic &lt;ldez@users.noreply.github.com&gt;
diff --git a/pkg/printers/sarif.go b/pkg/printers/sarif.go
@@ -76,7 +76,12 @@ func (p Sarif) Print(issues []result.Issue) error {
 		issue := issues[i]
 
 		severity := issue.Severity
-		if severity == "" {
+
+		switch severity {
+		// https://docs.oasis-open.org/sarif/sarif/v2.1.0/errata01/os/sarif-v2.1.0-errata01-os-complete.html#_Toc141790898
+		case "none", "note", "warning", "error":
+			// Valid levels.
+		default:
 			severity = "error"
 		}
 
diff --git a/pkg/printers/sarif_test.go b/pkg/printers/sarif_test.go
@@ -42,7 +42,7 @@ func TestSarif_Print(t *testing.T) {
 		},
 		{
 			FromLinter: "linter-a",
-			Severity:   "error",
+			Severity:   "low",
 			Text:       "some issue 2",
 			Pos: token.Position{
 				Filename: "path/to/filec.go",

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func TestSarif_Print(t *testing.T) {`
`42`	`42`	`},`
`43`	`43`	`{`
`44`	`44`	`FromLinter: "linter-a",`
`45`		`- Severity: "error",`
	`45`	`+ Severity: "low",`
`46`	`46`	`Text: "some issue 2",`
`47`	`47`	`Pos: token.Position{`
`48`	`48`	`Filename: "path/to/filec.go",`