Update megacheck (staticcheck) to 2019.1.1

Relates to #418

Author: jirfag

go.mod

@@ -14,7 +14,7 @@ require (
 	github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a
 	github.com/golangci/errcheck v0.0.0-20181003203344-ef45e06d44b6
 	github.com/golangci/go-misc v0.0.0-20180628070357-927a3d87b613
-	github.com/golangci/go-tools v0.0.0-20180109140146-35a9f45a5db0
+	github.com/golangci/go-tools v0.0.0-20180109140146-af6baa5dc196
 	github.com/golangci/goconst v0.0.0-20180610141641-041c5f2b40f3
 	github.com/golangci/gocyclo v0.0.0-20180528134321-2becd97e67ee
 	github.com/golangci/gofmt v0.0.0-20181105071733-0b8337e80d98

go.sum

@@ -48,8 +48,8 @@ github.com/golangci/errcheck v0.0.0-20181003203344-ef45e06d44b6 h1:i2jIkQFb8RG45
 github.com/golangci/errcheck v0.0.0-20181003203344-ef45e06d44b6/go.mod h1:DbHgvLiFKX1Sh2T1w8Q/h4NAI8MHIpzCdnBUDTXU3I0=
 github.com/golangci/go-misc v0.0.0-20180628070357-927a3d87b613 h1:9kfjN3AdxcbsZBf8NjltjWihK2QfBBBZuv91cMFfDHw=
 github.com/golangci/go-misc v0.0.0-20180628070357-927a3d87b613/go.mod h1:SyvUF2NxV+sN8upjjeVYr5W7tyxaT1JVtvhKhOn2ii8=
-github.com/golangci/go-tools v0.0.0-20180109140146-35a9f45a5db0 h1:tYc7NX0EeSyW9wFF0EXPB57lAiKRPwKZxVkaTsGuB9k=
-github.com/golangci/go-tools v0.0.0-20180109140146-35a9f45a5db0/go.mod h1:unzUULGw35sjyOYjUt0jMTXqHlZPpPc6e+xfO4cd6mM=
+github.com/golangci/go-tools v0.0.0-20180109140146-af6baa5dc196 h1:9rtVlONXLF1rJZzvLt4tfOXtnAFUEhxCJ64Ibzj6ECo=
+github.com/golangci/go-tools v0.0.0-20180109140146-af6baa5dc196/go.mod h1:unzUULGw35sjyOYjUt0jMTXqHlZPpPc6e+xfO4cd6mM=
 github.com/golangci/goconst v0.0.0-20180610141641-041c5f2b40f3 h1:pe9JHs3cHHDQgOFXJJdYkK6fLz2PWyYtP4hthoCMvs8=
 github.com/golangci/goconst v0.0.0-20180610141641-041c5f2b40f3/go.mod h1:JXrF4TWy4tXYn62/9x8Wm/K/dm06p8tCKwFRDPZG/1o=
 github.com/golangci/gocyclo v0.0.0-20180528134321-2becd97e67ee h1:J2XAy40+7yz70uaOiMbNnluTg7gyQhtGqLQncQh+4J8=

test/testdata/gosimple.go

@@ -1,25 +1,30 @@
 //args: -Egosimple
 package testdata
 
-import "strings"
+import (
+	"log"
+)
 
-func Gosimple(id1, s1 string) string {
-	if strings.HasPrefix(id1, s1) { // ERROR "should replace.*with.*strings.TrimPrefix"
-		id1 = strings.TrimPrefix(id1, s1)
+func Gosimple(ss []string) {
+	if ss != nil { // ERROR "S1031: unnecessary nil check around range"
+		for _, s := range ss {
+			log.Printf(s)
+		}
 	}
-	return id1
 }
 
-func GosimpleNolintGosimple(id1, s1 string) string {
-	if strings.HasPrefix(id1, s1) { //nolint:gosimple
-		id1 = strings.TrimPrefix(id1, s1)
+func GosimpleNolintGosimple(ss []string) {
+	if ss != nil { //nolint:gosimple
+		for _, s := range ss {
+			log.Printf(s)
+		}
 	}
-	return id1
 }
 
-func GosimpleNolintMegacheck(id1, s1 string) string {
-	if strings.HasPrefix(id1, s1) { //nolint:megacheck
-		id1 = strings.TrimPrefix(id1, s1)
+func GosimpleNolintMegacheck(ss []string) {
+	if ss != nil { //nolint:megacheck
+		for _, s := range ss {
+			log.Printf(s)
+		}
 	}
-	return id1
 }

test/testdata/stylecheck.go

@@ -2,19 +2,34 @@
 package testdata
 
 func Stylecheck(x int) {
-	if 0 == x { // ERROR "don't use Yoda conditions"
-		panic(x)
+	switch x {
+	case 1:
+		return
+	default: // ERROR "ST1015: default case should be first or last in switch statement"
+		return
+	case 2:
+		return
 	}
 }
 
 func StylecheckNolintStylecheck(x int) {
-	if 0 == x { //nolint:stylecheck
-		panic(x)
+	switch x {
+	case 1:
+		return
+	default: //nolint:stylecheck
+		return
+	case 2:
+		return
 	}
 }
 
 func StylecheckNolintMegacheck(x int) {
-	if 0 == x { //nolint:megacheck // ERROR "don't use Yoda conditions"
-		panic(x)
+	switch x {
+	case 1:
+		return
+	default: //nolint:megacheck // ERROR "ST1015: default case should be first or last in switch statement"
+		return
+	case 2:
+		return
 	}
 }