review

Author: ldez

.golangci.reference.yml

@@ -225,8 +225,8 @@ linters-settings:
     threshold: 100
 
   dupword:
-    # key words for detecting duplicate words, will override default value
-    # Default: the, and, a
+    # Keywords for detecting duplicate words, only the words defined in this list will be detected.
+    # Default: []
     keyword:
     - "the"
     - "and"

pkg/config/linters_settings.go

@@ -19,9 +19,6 @@ var defaultLintersSettings = LintersSettings{
 	Dogsled: DogsledSettings{
 		MaxBlankIdentifiers: 2,
 	},
-	DupWord: DupWordSettings{
-		KeyWord: []string{"the", "and", "a"},
-	},
 	ErrorLint: ErrorLintSettings{
 		Errorf:     true,
 		Asserts:    true,

pkg/golinters/dupword.go

@@ -4,23 +4,25 @@ import (
 	"strings"
 
 	"github.com/Abirdcfly/dupword"
-	"github.com/golangci/golangci-lint/pkg/config"
 	"golang.org/x/tools/go/analysis"
 
+	"github.com/golangci/golangci-lint/pkg/config"
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 )
 
 func NewDupWord(setting *config.DupWordSettings) *goanalysis.Linter {
 	a := dupword.NewAnalyzer()
+
 	cfgMap := map[string]map[string]interface{}{}
 	if setting != nil {
 		cfgMap[a.Name] = map[string]interface{}{
 			"keyword": strings.Join(setting.KeyWord, ","),
 		}
 	}
+
 	return goanalysis.NewLinter(
-		"dupword",
-		"checks for duplicate words in the source code (usually miswritten)",
+		a.Name,
+		"checks for duplicate words in the source code",
 		[]*analysis.Analyzer{a},
 		cfgMap,
 	).WithLoadMode(goanalysis.LoadModeSyntax)

pkg/lint/lintersdb/manager.go

@@ -344,7 +344,6 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 		linter.NewConfig(golinters.NewDupWord(dupwordCfg)).
 			WithSince("1.50.0").
 			WithPresets(linter.PresetComment).
-			WithLoadForGoAnalysis().
 			WithAutoFix().
 			WithURL("https://github.com/Abirdcfly/dupword"),