Skip to content

Commit 2b5a27a

Browse files
committed
feat: skip soft errors.
1 parent 950b9b6 commit 2b5a27a

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

pkg/golinters/goanalysis/runner_loadingpackage.go

+8
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,7 @@ func (lp *loadingPackage) decUse(canClearTypes bool) {
390390

391391
func (lp *loadingPackage) convertError(err error) []packages.Error {
392392
var errs []packages.Error
393+
393394
// taken from go/packages
394395
switch err := err.(type) {
395396
case packages.Error:
@@ -416,6 +417,12 @@ func (lp *loadingPackage) convertError(err error) []packages.Error {
416417

417418
case types.Error:
418419
// from type checker
420+
if err.Soft {
421+
// The meaning of soft is explained in types.Error godoc.
422+
// We skip this kind of error because they are handle by the other linters.
423+
return nil
424+
}
425+
419426
errs = append(errs, packages.Error{
420427
Pos: err.Fset.Position(err.Pos).String(),
421428
Msg: err.Msg,
@@ -433,6 +440,7 @@ func (lp *loadingPackage) convertError(err error) []packages.Error {
433440
// If you see this error message, please file a bug.
434441
lp.log.Warnf("Internal error: error %q (%T) without position", err, err)
435442
}
443+
436444
return errs
437445
}
438446

0 commit comments

Comments
 (0)