Skip to content

Add support for executing golangci-lint using go run method #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
artuross opened this issue Jan 31, 2023 · 1 comment
Closed
2 tasks done

Add support for executing golangci-lint using go run method #664

artuross opened this issue Jan 31, 2023 · 1 comment
Labels
duplicate This issue or pull request already exists

Comments

@artuross
Copy link

Welcome

  • Yes, I understand that the GitHub action repository is not the repository of golangci-lint itself.
  • Yes, I've searched similar issues on GitHub and didn't find any.

Your feature request related to a problem? Please describe.

This action already supports detecting version from go.mod file when version param is not set, but the golangci-lint binary is still downloaded from the internet. This may be unwanted for security reasons, but also since Go is already aware of what makes up golangci-lint executable, I believe a better approach would be to use Go to run the binary.

Describe the solution you'd like.

Instead of fetching binary version from the internet, it can be run as go run github.com/golangci/golangci-lint/cmd/golangci-lint ... which will use the version defined in Go modules.

Describe alternatives you've considered.

  • current approach with downloading binaries from the internet
  • specifying custom download path

Additional context.

No response

@ldez
Copy link
Member

ldez commented Mar 20, 2023

Duplicate of #540

@ldez ldez marked this as a duplicate of #540 Mar 20, 2023
@ldez ldez closed this as completed Mar 20, 2023
@ldez ldez added the duplicate This issue or pull request already exists label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants