Skip to content
This repository was archived by the owner on Jun 2, 2023. It is now read-only.

Commit 6e6a3cf

Browse files
committed
pass log child to analyzers
1 parent 5c20fbd commit 6e6a3cf

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

pkg/worker/app/app.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -84,25 +84,25 @@ func (a *App) buildDeps() {
8484
}
8585
}
8686

87-
func (a App) buildMultiplexer() *consumers.Multiplexer {
87+
func (a App) buildMultiplexer(log logutil.Log) *consumers.Multiplexer {
8888
rpf := processors.NewRepoProcessorFactory(&processors.StaticRepoConfig{})
8989

90-
// it's important to use a.log, not a.trackedLog
91-
repoAnalyzer := analyzesConsumers.NewAnalyzeRepo(rpf, a.log, a.errTracker, a.cfg, a.ec)
90+
// it's important to use log (a.log.Child), not a.trackedLog
91+
repoAnalyzer := analyzesConsumers.NewAnalyzeRepo(rpf, log, a.errTracker, a.cfg, a.ec)
9292
repoAnalyzesRunner := repoanalyzesqueue.NewConsumer(repoAnalyzer)
9393

94-
// it's important to use a.log, not a.trackedLog
95-
pullAnalyzer := analyzesConsumers.NewAnalyzePR(a.ppf, a.log, a.errTracker, a.cfg, a.ec)
94+
// it's important to use log (a.log.Child), not a.trackedLog
95+
pullAnalyzer := analyzesConsumers.NewAnalyzePR(a.ppf, log, a.errTracker, a.cfg, a.ec)
9696
pullAnalyzesRunner := pullanalyzesqueue.NewConsumer(pullAnalyzer)
9797

9898
multiplexer := consumers.NewMultiplexer()
9999
multiplexer.SetResultLogger(func(error) {}) // already logged, no double logging
100100

101101
if err := repoAnalyzesRunner.Register(multiplexer, a.distLockFactory); err != nil {
102-
a.log.Fatalf("Failed to register repo analyzer consumer: %s", err)
102+
log.Fatalf("Failed to register repo analyzer consumer: %s", err)
103103
}
104104
if err := pullAnalyzesRunner.Register(multiplexer, a.distLockFactory); err != nil {
105-
a.log.Fatalf("Failed to register pull analyzer consumer: %s", err)
105+
log.Fatalf("Failed to register pull analyzer consumer: %s", err)
106106
}
107107

108108
return multiplexer
@@ -144,8 +144,6 @@ func (a App) BuildTestDeps() *TestDeps {
144144
}
145145

146146
func (a App) Run() {
147-
consumerMultiplexer := a.buildMultiplexer()
148-
149147
consumersCount := a.cfg.GetInt("CONSUMERS_COUNT", 1)
150148
a.log.Infof("Starting %d consumers...", consumersCount)
151149

@@ -155,7 +153,9 @@ func (a App) Run() {
155153
go func(i int) {
156154
defer wg.Done()
157155

158-
trackedLog := a.trackedLog.Child(fmt.Sprintf("consumer #%d", i))
156+
logName := fmt.Sprintf("consumer #%d", i)
157+
consumerMultiplexer := a.buildMultiplexer(a.log.Child(logName))
158+
trackedLog := a.trackedLog.Child(logName)
159159
analyzesSQS := sqs.NewQueue(a.cfg.GetString("SQS_ANALYZES_QUEUE_URL"),
160160
a.awsSess, trackedLog, analyzesqueue.VisibilityTimeoutSec)
161161
consumer := consumer.NewSQS(trackedLog, a.cfg, analyzesSQS,

0 commit comments

Comments
 (0)