Merge pull request timakin#17 from golangci/master

timakin · web-flow · commit 87058b9bfcec · 2019-07-21T12:02:26.000+09:00
fix timakin#8, fix timakin#16: fix parallel writes to runner
diff --git a/passes/bodyclose/bodyclose.go b/passes/bodyclose/bodyclose.go
@@ -38,7 +38,9 @@ type runner struct {
 	skipFile  map[*ast.File]bool
 }
 
-func (r *runner) run(pass *analysis.Pass) (interface{}, error) {
+// run executes an analysis for the pass. The receiver is passed
+// by value because this func is called in parallel for different passes.
+func (r runner) run(pass *analysis.Pass) (interface{}, error) {
 	r.pass = pass
 	funcs := pass.ResultOf[buildssa.Analyzer].(*buildssa.SSA).SrcFuncs
 

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,9 @@ type runner struct {`
`38`	`38`	`skipFile map[*ast.File]bool`
`39`	`39`	`}`
`40`	`40`
`41`		`-func (r runner) run(pass analysis.Pass) (interface{}, error) {`
	`41`	`+// run executes an analysis for the pass. The receiver is passed`
	`42`	`+// by value because this func is called in parallel for different passes.`
	`43`	`+func (r runner) run(pass *analysis.Pass) (interface{}, error) {`
`42`	`44`	`r.pass = pass`
`43`	`45`	`funcs := pass.ResultOf[buildssa.Analyzer].(*buildssa.SSA).SrcFuncs`
`44`	`46`