Skip to content

Commit c5b00d9

Browse files
matloobianthehat
authored andcommitted
go/packages: fix build breakage caused by math/bits to unsafe dep
Our tests compare import graphs from go/packages to expected graphs, and one of the test cases imports math/bits. But in tip math/bits picked up a dependency on unsafe, which means the expected graph is different when run against a Go version >= go1.11. Remove that edge before comparing against the expected graph to work around the breakage. Change-Id: Ic586a75ba530741d251df9f87d0817a8e37d92ea Reviewed-on: https://go-review.googlesource.com/c/151657 Run-TryBot: Michael Matloob <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Cottrell <[email protected]>
1 parent e782529 commit c5b00d9

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

go/packages/packages_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1600,6 +1600,12 @@ func importGraph(initial []*packages.Package) (string, map[string]*packages.Pack
16001600
continue
16011601
}
16021602
}
1603+
// math/bits took on a dependency on unsafe in 1.12, which breaks some
1604+
// tests. As a short term hack, prune that edge.
1605+
// TODO(matloob): think of a cleaner solution, or remove math/bits from the test.
1606+
if p.ID == "math/bits" && imp.ID == "unsafe" {
1607+
continue
1608+
}
16031609
edges = append(edges, fmt.Sprintf("%s -> %s", p, imp))
16041610
visit(imp)
16051611
}

0 commit comments

Comments
 (0)