Skip to content

Commit 8e0240a

Browse files
committed
internal/regtest/workspace: permanently skip TestDeleteModule_Interdependent
This test is flaky, likely due to some race in the experimentalWorkspaceModule logic. Since we're about to delete support for that experimental feature, simply skip the test to stop the flakes. Leave the test as an artifact, as it will be deleted as part of the clean up of experimentalWorkspaceModule. No need to delete it before then. Updates golang/go#55331 Fixes golang/go#55923 Change-Id: Ic17485e42e335459df462af00a2088812ecfb5f4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/448116 Reviewed-by: Alan Donovan <[email protected]> gopls-CI: kokoro <[email protected]> Run-TryBot: Robert Findley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Robert Findley <[email protected]>
1 parent fe725d9 commit 8e0240a

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

gopls/internal/regtest/workspace/workspace_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,12 @@ func main() {
335335

336336
// This change tests that the version of the module used changes after it has
337337
// been deleted from the workspace.
338+
//
339+
// TODO(golang/go#55331): delete this placeholder along with experimental
340+
// workspace module.
338341
func TestDeleteModule_Interdependent(t *testing.T) {
342+
t.Skip("golang/go#55331: the experimental workspace module is scheduled for deletion")
343+
339344
const multiModule = `
340345
-- moda/a/go.mod --
341346
module a.com

0 commit comments

Comments
 (0)