Skip to content

Commit 839de22

Browse files
codyossgopherbot
authored andcommitted
google: don't check for IsNotExist for well-known file
There are cases when reading this file that a ENOTDIR is returned. Because of this it is safer to just fall-back when any error happens from reading the gcloud file. Change-Id: Ie8e45ad508643e900adb5c9787907aaa50cceb5d Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/493695 Run-TryBot: Cody Oss <[email protected]> Reviewed-by: Russ Cox <[email protected]> Auto-Submit: Cody Oss <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 0690208 commit 839de22

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

google/default.go

+3-6
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import (
88
"context"
99
"encoding/json"
1010
"fmt"
11-
"io/ioutil"
1211
"net/http"
1312
"os"
1413
"path/filepath"
@@ -142,10 +141,8 @@ func FindDefaultCredentialsWithParams(ctx context.Context, params CredentialsPar
142141

143142
// Second, try a well-known file.
144143
filename := wellKnownFile()
145-
if creds, err := readCredentialsFile(ctx, filename, params); err == nil {
146-
return creds, nil
147-
} else if !os.IsNotExist(err) {
148-
return nil, fmt.Errorf("google: error getting credentials using well-known file (%v): %v", filename, err)
144+
if b, err := os.ReadFile(filename); err == nil {
145+
return CredentialsFromJSONWithParams(ctx, b, params)
149146
}
150147

151148
// Third, if we're on a Google App Engine standard first generation runtime (<= Go 1.9)
@@ -231,7 +228,7 @@ func wellKnownFile() string {
231228
}
232229

233230
func readCredentialsFile(ctx context.Context, filename string, params CredentialsParams) (*Credentials, error) {
234-
b, err := ioutil.ReadFile(filename)
231+
b, err := os.ReadFile(filename)
235232
if err != nil {
236233
return nil, err
237234
}

0 commit comments

Comments
 (0)